Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Unified Diff: rlz/chromeos/lib/rlz_value_store_chromeos.h

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: rlz/chromeos/lib/rlz_value_store_chromeos.h
diff --git a/rlz/chromeos/lib/rlz_value_store_chromeos.h b/rlz/chromeos/lib/rlz_value_store_chromeos.h
index 9f925498f54623e3089648859f91d0dc890c7db4..946d56b290c6300309b768806c21c5ffeebac93d 100644
--- a/rlz/chromeos/lib/rlz_value_store_chromeos.h
+++ b/rlz/chromeos/lib/rlz_value_store_chromeos.h
@@ -64,9 +64,10 @@ class RlzValueStoreChromeOS : public RlzValueStore,
void WriteStore();
// Adds |value| to list at |list_name| path in JSON store.
- bool AddValueToList(std::string list_name, base::Value* value);
+ bool AddValueToList(const std::string& list_name, base::Value* value);
// Removes |value| from list at |list_name| path in JSON store.
- bool RemoveValueFromList(std::string list_name, const base::Value& value);
+ bool RemoveValueFromList(const std::string& list_name,
+ const base::Value& value);
// In-memory store with RLZ data.
scoped_ptr<base::DictionaryValue> rlz_store_;

Powered by Google App Engine
This is Rietveld 408576698