Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Unified Diff: net/test/embedded_test_server/tcp_listen_socket_unittest.h

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/test/embedded_test_server/tcp_listen_socket_unittest.h
diff --git a/net/test/embedded_test_server/tcp_listen_socket_unittest.h b/net/test/embedded_test_server/tcp_listen_socket_unittest.h
index b1c4022e943dd1f8dcdecc37a46032e86d2bf755..949e6311363560630791a7489c9f3459b45d4382 100644
--- a/net/test/embedded_test_server/tcp_listen_socket_unittest.h
+++ b/net/test/embedded_test_server/tcp_listen_socket_unittest.h
@@ -46,7 +46,7 @@ class TCPListenSocketTestAction {
public:
TCPListenSocketTestAction() : action_(ACTION_NONE) {}
explicit TCPListenSocketTestAction(ActionType action) : action_(action) {}
- TCPListenSocketTestAction(ActionType action, std::string data)
+ TCPListenSocketTestAction(ActionType action, const std::string& data)
: action_(action), data_(data) {}
const std::string& data() const { return data_; }
« no previous file with comments | « net/spdy/spdy_protocol.h ('k') | net/tools/flip_server/spdy_util.h » ('j') | url/gurl.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698