net/spdy/spdy_alt_svc_wire_format_test.cc - Issue 1349783006: Cleanup: Pass std::string as const reference if possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/spdy_alt_svc_wire_format_test.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert third_party changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/spdy/spdy_alt_svc_wire_format_test.cc

diff --git a/net/spdy/spdy_alt_svc_wire_format_test.cc b/net/spdy/spdy_alt_svc_wire_format_test.cc

index 9113c3b80d3a4aa27c1fff192bb08b6e3b6936eb..f4cb0cbc262cbfdd0d785684f6cc9ab8cd975f93 100644

--- a/net/spdy/spdy_alt_svc_wire_format_test.cc

+++ b/net/spdy/spdy_alt_svc_wire_format_test.cc

@@ -263,7 +263,7 @@ TEST(SpdyAltSvcWireFormatTest, ParseTruncatedHeaderFieldValue) {

SpdyAltSvcWireFormat::AlternativeServiceVector altsvc_vector;

const char* field_value_array[] = {

"p=\":137\"", "p=\"foo:137\"", "p%25=\"foo\\\"bar\\\\baz:137\""};

- for (std::string field_value : field_value_array) {

+ for (const std::string& field_value : field_value_array) {

for (size_t len = 1; len < field_value.size(); ++len) {

EXPECT_FALSE(SpdyAltSvcWireFormat::ParseHeaderFieldValue(

field_value.substr(0, len), &altsvc_vector))

« no previous file with comments | « net/socket/tcp_server_socket_unittest.cc ('k') | net/spdy/spdy_pinnable_buffer_piece_test.cc » ('j') | url/gurl.h » ('J')