Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: net/base/ip_pattern_unittest.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/ip_pattern_unittest.cc
diff --git a/net/base/ip_pattern_unittest.cc b/net/base/ip_pattern_unittest.cc
index 5e06cd69a1c709928c2a2e73899bf3915723df88..feec18dd505806775049fffd589c3542c8b56a31 100644
--- a/net/base/ip_pattern_unittest.cc
+++ b/net/base/ip_pattern_unittest.cc
@@ -16,7 +16,7 @@ bool IsValidPattern(const std::string& pattern_text) {
return pattern.ParsePattern(pattern_text);
}
-bool CheckForMatch(const IPPattern& pattern, std::string address_text) {
+bool CheckForMatch(const IPPattern& pattern, const std::string& address_text) {
IPAddressNumber address;
EXPECT_TRUE(ParseIPLiteralToNumber(address_text, &address));
return pattern.Match(address);

Powered by Google App Engine
This is Rietveld 408576698