ios/web/navigation/crw_session_controller_unittest.mm - Issue 1349783006: Cleanup: Pass std::string as const reference if possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/navigation/crw_session_controller_unittest.mm

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert third_party changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ios/web/navigation/crw_session_controller_unittest.mm

diff --git a/ios/web/navigation/crw_session_controller_unittest.mm b/ios/web/navigation/crw_session_controller_unittest.mm

index bd4e69310b7b65644e328353442cf83d70d49781..8a9171c2bddaf934ea1c52ae19216b3634c7cb29 100644

--- a/ios/web/navigation/crw_session_controller_unittest.mm

+++ b/ios/web/navigation/crw_session_controller_unittest.mm

@@ -51,7 +51,7 @@ class CRWSessionControllerTest : public PlatformTest {

browserState:&browser_state_]);

}

- web::Referrer MakeReferrer(std::string url) {

+ web::Referrer MakeReferrer(const std::string& url) {

return web::Referrer(GURL(url), web::ReferrerPolicyDefault);

}

« no previous file with comments | « ios/crnet/crnet_environment.mm ('k') | ipc/ipc_sync_message_unittest.cc » ('j') | url/gurl.h » ('J')