gpu/command_buffer/service/texture_manager_unittest.cc - Issue 1349783006: Cleanup: Pass std::string as const reference if possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/texture_manager_unittest.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert third_party changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gpu/command_buffer/service/texture_manager_unittest.cc

diff --git a/gpu/command_buffer/service/texture_manager_unittest.cc b/gpu/command_buffer/service/texture_manager_unittest.cc

index f9642b8d1a2585e9645899e463117a260685298c..bdb9328bd023a3d63b58cb289b325447b8ac0260 100644

--- a/gpu/command_buffer/service/texture_manager_unittest.cc

+++ b/gpu/command_buffer/service/texture_manager_unittest.cc

@@ -481,7 +481,7 @@ class TextureTestBase : public GpuServiceTest {

~TextureTestBase() override { texture_ref_ = NULL; }

protected:

- void SetUpBase(MemoryTracker* memory_tracker, std::string extensions) {

+ void SetUpBase(MemoryTracker* memory_tracker, const std::string& extensions) {

GpuServiceTest::SetUp();

if (!extensions.empty()) {

TestHelper::SetupFeatureInfoInitExpectations(gl_.get(),

« no previous file with comments | « gpu/command_buffer/service/gles2_cmd_decoder.cc ('k') | gpu/config/gpu_blacklist_unittest.cc » ('j') | url/gurl.h » ('J')