Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Unified Diff: content/renderer/media/webrtc/media_stream_track_metrics_unittest.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/webrtc/media_stream_track_metrics_unittest.cc
diff --git a/content/renderer/media/webrtc/media_stream_track_metrics_unittest.cc b/content/renderer/media/webrtc/media_stream_track_metrics_unittest.cc
index d18c04f9e4ce7c6ec41d4683839fe2933fbc2bae..df840835b0a616fb2ded090c04e7e5cea2e876f1 100644
--- a/content/renderer/media/webrtc/media_stream_track_metrics_unittest.cc
+++ b/content/renderer/media/webrtc/media_stream_track_metrics_unittest.cc
@@ -132,11 +132,11 @@ class MediaStreamTrackMetricsTest : public testing::Test {
void AddVideoTrack(VideoTrackInterface* track) { AddTrack(track); }
void RemoveVideoTrack(VideoTrackInterface* track) { RemoveTrack(track); }
- scoped_refptr<MockAudioTrackInterface> MakeAudioTrack(std::string id) {
+ scoped_refptr<MockAudioTrackInterface> MakeAudioTrack(const std::string& id) {
return new rtc::RefCountedObject<MockAudioTrackInterface>(id);
}
- scoped_refptr<MockVideoTrackInterface> MakeVideoTrack(std::string id) {
+ scoped_refptr<MockVideoTrackInterface> MakeVideoTrack(const std::string& id) {
return new rtc::RefCountedObject<MockVideoTrackInterface>(id);
}

Powered by Google App Engine
This is Rietveld 408576698