Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1362)

Unified Diff: content/child/resource_dispatcher_unittest.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/resource_dispatcher_unittest.cc
diff --git a/content/child/resource_dispatcher_unittest.cc b/content/child/resource_dispatcher_unittest.cc
index 84c67fe63745e8b26142ef4b53f58136b2236814..fc1cb16e8a3db870c29562db2fb043658e141264 100644
--- a/content/child/resource_dispatcher_unittest.cc
+++ b/content/child/resource_dispatcher_unittest.cc
@@ -299,7 +299,7 @@ class ResourceDispatcherTest : public testing::Test, public IPC::Sender {
shared_memory->requested_size(), 0)));
}
- void NotifyDataReceived(int request_id, std::string data) {
+ void NotifyDataReceived(int request_id, const std::string& data) {
ASSERT_LE(data.length(), shared_memory_map_[request_id]->requested_size());
memcpy(shared_memory_map_[request_id]->memory(), data.c_str(),
data.length());

Powered by Google App Engine
This is Rietveld 408576698