content/browser/renderer_host/render_widget_host_view_browsertest.cc - Issue 1349783006: Cleanup: Pass std::string as const reference if possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_browsertest.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert third_party changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/renderer_host/render_widget_host_view_browsertest.cc

diff --git a/content/browser/renderer_host/render_widget_host_view_browsertest.cc b/content/browser/renderer_host/render_widget_host_view_browsertest.cc

index 905425c4b2e2e6dadf1655c5bb02b0ee92f14bd5..0ddf9a8a8a1086cc0ec22e1ceb097db34237e13f 100644

--- a/content/browser/renderer_host/render_widget_host_view_browsertest.cc

+++ b/content/browser/renderer_host/render_widget_host_view_browsertest.cc

@@ -520,7 +520,7 @@ class CompositingRenderWidgetHostViewBrowserTestTabCapture

GURL TestUrl() override { return GURL(test_url_); }

- void SetTestUrl(std::string url) { test_url_ = url; }

+ void SetTestUrl(const std::string& url) { test_url_ = url; }

// Loads a page two boxes side-by-side, each half the width of

// |html_rect_size|, and with different background colors. The test then

« no previous file with comments | « content/browser/renderer_host/p2p/socket_host_test_utils.cc ('k') | content/browser/session_history_browsertest.cc » ('j') | url/gurl.h » ('J')