components/variations/service/variations_service_unittest.cc - Issue 1349783006: Cleanup: Pass std::string as const reference if possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/variations/service/variations_service_unittest.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert third_party changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/variations/service/variations_service_unittest.cc

diff --git a/components/variations/service/variations_service_unittest.cc b/components/variations/service/variations_service_unittest.cc

index 2d75afbc504947e0330aea2a9c47b5b89ad73de9..aeb5c199f69479eb565939f408b3f2936465a65f 100644

--- a/components/variations/service/variations_service_unittest.cc

+++ b/components/variations/service/variations_service_unittest.cc

@@ -60,7 +60,7 @@ class TestVariationsServiceClient : public VariationsServiceClient {

void OverrideUIString(uint32_t hash, const base::string16& string) override {}

void OnInitialStartup() override {}

- void set_restrict_parameter(std::string value) {

+ void set_restrict_parameter(const std::string& value) {

restrict_parameter_ = value;

}

« no previous file with comments | « components/user_prefs/tracked/tracked_preferences_migration_unittest.cc ('k') | content/browser/device_monitor_mac.mm » ('j') | url/gurl.h » ('J')