components/certificate_transparency/log_proof_fetcher_unittest.cc - Issue 1349783006: Cleanup: Pass std::string as const reference if possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/certificate_transparency/log_proof_fetcher_unittest.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert third_party changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cdm/renderer/widevine_key_systems.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc » ('j') | url/gurl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/certificate_transparency/log_proof_fetcher_unittest.cc

diff --git a/components/certificate_transparency/log_proof_fetcher_unittest.cc b/components/certificate_transparency/log_proof_fetcher_unittest.cc

index 945325e533fc157ce3bbb3dd483af535da8524e7..a61da011b09199bd2a734e66282400fa1156ef91 100644

--- a/components/certificate_transparency/log_proof_fetcher_unittest.cc

+++ b/components/certificate_transparency/log_proof_fetcher_unittest.cc

@@ -98,11 +98,11 @@ class GetSTHResponseHandler : public net::URLRequestInterceptor {

return job;

}

- void set_response_body(std::string response_body) {

+ void set_response_body(const std::string& response_body) {

response_body_ = response_body;

}

- void set_response_headers(std::string response_headers) {

+ void set_response_headers(const std::string& response_headers) {

response_headers_ = response_headers;

}