chromeos/network/shill_property_util.h - Issue 1349783006: Cleanup: Pass std::string as const reference if possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/network/shill_property_util.h

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert third_party changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chromeos/network/shill_property_util.h

diff --git a/chromeos/network/shill_property_util.h b/chromeos/network/shill_property_util.h

index cc9da9c24377dbe0f6e1ba028d8cca709c4c7f73..f585da4086e12a27f01ed032df9cac1755a3e6a8 100644

--- a/chromeos/network/shill_property_util.h

+++ b/chromeos/network/shill_property_util.h

@@ -22,7 +22,7 @@ class NetworkUIData;

namespace shill_property_util {

// Sets the |ssid| in |properties|.

-CHROMEOS_EXPORT void SetSSID(const std::string ssid,

+CHROMEOS_EXPORT void SetSSID(const std::string& ssid,

base::DictionaryValue* properties);

// Returns the SSID from |properties| in UTF-8 encoding. If |verbose_logging| is

« no previous file with comments | « chromeos/network/onc/onc_certificate_importer_impl_unittest.cc ('k') | chromeos/network/shill_property_util.cc » ('j') | url/gurl.h » ('J')