chrome_elf/dll_hash/dll_hash.h - Issue 1349783006: Cleanup: Pass std::string as const reference if possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome_elf/dll_hash/dll_hash.h

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert third_party changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome_elf/dll_hash/dll_hash.h

diff --git a/chrome_elf/dll_hash/dll_hash.h b/chrome_elf/dll_hash/dll_hash.h

index 82bec8af1cd6c438349879ab0a0de8988f99390f..2cfca818eee2b468a87a4a8935841234eb4ec153 100644

--- a/chrome_elf/dll_hash/dll_hash.h

+++ b/chrome_elf/dll_hash/dll_hash.h

@@ -8,6 +8,6 @@

#include <string>

// Convert a dll name to a hash that can be sent via UMA.

-int DllNameToHash(std::string dll_name);

+int DllNameToHash(const std::string& dll_name);

#endif // CHROME_ELF_DLL_HASH_DLL_HASH_H_

« no previous file with comments | « chrome/utility/importer/firefox_importer_unittest_utils_mac.cc ('k') | chrome_elf/dll_hash/dll_hash.cc » ('j') | url/gurl.h » ('J')