chrome/browser/profiles/profile_list_desktop_unittest.cc - Issue 1349783006: Cleanup: Pass std::string as const reference if possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/profiles/profile_list_desktop_unittest.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert third_party changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/profiles/profile_list_desktop_unittest.cc

diff --git a/chrome/browser/profiles/profile_list_desktop_unittest.cc b/chrome/browser/profiles/profile_list_desktop_unittest.cc

index bd79226cf028f4d07267c4ccb144e1d0e8790cba..553f875eb59fd8e848a02d107b135f0314d90cb8 100644

--- a/chrome/browser/profiles/profile_list_desktop_unittest.cc

+++ b/chrome/browser/profiles/profile_list_desktop_unittest.cc

@@ -73,7 +73,7 @@ class ProfileListDesktopTest : public testing::Test {

TestingProfileManager* manager() { return &manager_; }

- void AddOmittedProfile(std::string name) {

+ void AddOmittedProfile(const std::string& name) {

ProfileInfoCache* cache = manager()->profile_info_cache();

cache->AddProfileToCache(

cache->GetUserDataDir().AppendASCII(name), ASCIIToUTF16(name),

« no previous file with comments | « chrome/browser/pdf/pdf_extension_test.cc ('k') | chrome/browser/safe_browsing/client_side_detection_service_unittest.cc » ('j') | url/gurl.h » ('J')