chrome/browser/media_galleries/media_galleries_scan_result_controller.cc - Issue 1349783006: Cleanup: Pass std::string as const reference if possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media_galleries/media_galleries_scan_result_controller.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert third_party changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media_galleries/media_galleries_scan_result_controller.h ('k') | chrome/browser/nacl_host/test/gdb_debug_stub_browsertest.cc » ('j') | url/gurl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media_galleries/media_galleries_scan_result_controller.cc

diff --git a/chrome/browser/media_galleries/media_galleries_scan_result_controller.cc b/chrome/browser/media_galleries/media_galleries_scan_result_controller.cc

index 1b791b28747fa702544d482954a50f9633a34ea6..263d1e7e162813eedd472bb7728c95cd1cd06ff9 100644

--- a/chrome/browser/media_galleries/media_galleries_scan_result_controller.cc

+++ b/chrome/browser/media_galleries/media_galleries_scan_result_controller.cc

@@ -329,7 +329,7 @@ void MediaGalleriesScanResultController::OnPreferenceUpdate(

}

void MediaGalleriesScanResultController::OnRemovableDeviceUpdate(

- const std::string device_id) {

+ const std::string& device_id) {

for (ScanResults::const_iterator it = scan_results_.begin();

it != scan_results_.end();

++it) {