chrome/browser/extensions/extension_browsertest.h - Issue 1349783006: Cleanup: Pass std::string as const reference if possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_browsertest.h

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert third_party changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.cc ('k') | chrome/browser/extensions/extension_browsertest.cc » ('j') | url/gurl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_browsertest.h

diff --git a/chrome/browser/extensions/extension_browsertest.h b/chrome/browser/extensions/extension_browsertest.h

index f4733aaebd8f9bdf62da3458c25f95288de6a498..0f3b1a33468660bcff6feafd7a873bccf82a1df2 100644

--- a/chrome/browser/extensions/extension_browsertest.h

+++ b/chrome/browser/extensions/extension_browsertest.h

@@ -228,7 +228,7 @@ class ExtensionBrowserTest : virtual public InProcessBrowserTest {

std::string(), path, INSTALL_UI_TYPE_CANCEL, 0);

}

- void ReloadExtension(const std::string extension_id);

+ void ReloadExtension(const std::string& extension_id);

void UnloadExtension(const std::string& extension_id);