chrome/browser/extensions/api/system_indicator/system_indicator_manager.h - Issue 1349783006: Cleanup: Pass std::string as const reference if possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/system_indicator/system_indicator_manager.h

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert third_party changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/notifications/notifications_apitest.cc ('k') | chrome/browser/extensions/api/system_indicator/system_indicator_manager.cc » ('j') | url/gurl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/system_indicator/system_indicator_manager.h

diff --git a/chrome/browser/extensions/api/system_indicator/system_indicator_manager.h b/chrome/browser/extensions/api/system_indicator/system_indicator_manager.h

index 040c216f8e649433634d4ee98c3633e1afa3f39b..e39926a7b94b5a35dda27df4f2c3ded6d0527790 100644

--- a/chrome/browser/extensions/api/system_indicator/system_indicator_manager.h

+++ b/chrome/browser/extensions/api/system_indicator/system_indicator_manager.h

@@ -55,7 +55,7 @@ class SystemIndicatorManager : public ExtensionRegistryObserver,

// Causes a call to OnStatusIconClicked for the specified extension_id.

// Returns false if no ExtensionIndicatorIcon is found for the extension.

- bool SendClickEventToExtensionForTest(const std::string extension_id);

+ bool SendClickEventToExtensionForTest(const std::string& extension_id);

// Causes an indicator to be shown for the given extension_action. Creates

// the indicator if necessary.

@@ -64,7 +64,7 @@ class SystemIndicatorManager : public ExtensionRegistryObserver,

ExtensionAction* extension_action);

// Causes the indicator for the given extension to be hidden.

- void RemoveIndicator(const std::string &extension_id);

+ void RemoveIndicator(const std::string& extension_id);

typedef std::map<const std::string, linked_ptr<ExtensionIndicatorIcon> >

SystemIndicatorMap;