chrome/browser/chromeos/login/kiosk_browsertest.cc - Issue 1349783006: Cleanup: Pass std::string as const reference if possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/kiosk_browsertest.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert third_party changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/input_method/input_method_manager_impl.cc ('k') | chrome/browser/chromeos/login/screens/hid_detection_screen.h » ('j') | url/gurl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/kiosk_browsertest.cc

diff --git a/chrome/browser/chromeos/login/kiosk_browsertest.cc b/chrome/browser/chromeos/login/kiosk_browsertest.cc

index e8b1dc7e243dab061ad607fa34dbebab12b757a9..65554420ff368704d86f26f5228df0f6a9af76fe 100644

--- a/chrome/browser/chromeos/login/kiosk_browsertest.cc

+++ b/chrome/browser/chromeos/login/kiosk_browsertest.cc

@@ -198,7 +198,7 @@ void LockAndUnlock(scoped_ptr<base::Lock> lock) {

lock->Release();

}

-bool IsAppInstalled(const std::string app_id) {

+bool IsAppInstalled(const std::string& app_id) {

Profile* app_profile = ProfileManager::GetPrimaryUserProfile();

DCHECK(app_profile);

const extensions::Extension* app =

@@ -1353,7 +1353,7 @@ class KioskUpdateTest : public KioskTest {

EXPECT_EQ(version, cached_version);

}

- void SetupFakeDiskMountManagerMountPath(const std::string mount_path) {

+ void SetupFakeDiskMountManagerMountPath(const std::string& mount_path) {

base::FilePath test_data_dir;

PathService::Get(chrome::DIR_TEST_DATA, &test_data_dir);

test_data_dir = test_data_dir.AppendASCII(mount_path);