Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Side by Side Diff: sync/test/fake_server/bookmark_entity.h

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef SYNC_TEST_FAKE_SERVER_BOOKMARK_ENTITY_H_ 5 #ifndef SYNC_TEST_FAKE_SERVER_BOOKMARK_ENTITY_H_
6 #define SYNC_TEST_FAKE_SERVER_BOOKMARK_ENTITY_H_ 6 #define SYNC_TEST_FAKE_SERVER_BOOKMARK_ENTITY_H_
7 7
8 #include <map> 8 #include <map>
9 #include <string> 9 #include <string>
10 10
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 const std::string& name, 42 const std::string& name,
43 const std::string& originator_cache_guid, 43 const std::string& originator_cache_guid,
44 const std::string& originator_client_item_id, 44 const std::string& originator_client_item_id,
45 const sync_pb::UniquePosition& unique_position, 45 const sync_pb::UniquePosition& unique_position,
46 const sync_pb::EntitySpecifics& specifics, 46 const sync_pb::EntitySpecifics& specifics,
47 bool is_folder, 47 bool is_folder,
48 const std::string& parent_id, 48 const std::string& parent_id,
49 int64 creation_time, 49 int64 creation_time,
50 int64 last_modified_time); 50 int64 last_modified_time);
51 51
52 void SetParentId(std::string parent_id); 52 void SetParentId(const std::string& parent_id);
53 53
54 // FakeServerEntity implementation. 54 // FakeServerEntity implementation.
55 std::string GetParentId() const override; 55 std::string GetParentId() const override;
56 void SerializeAsProto(sync_pb::SyncEntity* proto) const override; 56 void SerializeAsProto(sync_pb::SyncEntity* proto) const override;
57 bool IsFolder() const override; 57 bool IsFolder() const override;
58 58
59 private: 59 private:
60 // All member values have equivalent fields in SyncEntity. 60 // All member values have equivalent fields in SyncEntity.
61 std::string originator_cache_guid_; 61 std::string originator_cache_guid_;
62 std::string originator_client_item_id_; 62 std::string originator_client_item_id_;
63 sync_pb::UniquePosition unique_position_; 63 sync_pb::UniquePosition unique_position_;
64 bool is_folder_; 64 bool is_folder_;
65 std::string parent_id_; 65 std::string parent_id_;
66 int64 creation_time_; 66 int64 creation_time_;
67 int64 last_modified_time_; 67 int64 last_modified_time_;
68 }; 68 };
69 69
70 } // namespace fake_server 70 } // namespace fake_server
71 71
72 #endif // SYNC_TEST_FAKE_SERVER_BOOKMARK_ENTITY_H_ 72 #endif // SYNC_TEST_FAKE_SERVER_BOOKMARK_ENTITY_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698