net/tools/flip_server/spdy_util.h - Issue 1349783006: Cleanup: Pass std::string as const reference if possible

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/tools/flip_server/spdy_util.h

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert third_party changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef NET_TOOLS_FLIP_SERVER_SPDY_UTIL_H_	5 #ifndef NET_TOOLS_FLIP_SERVER_SPDY_UTIL_H_

6 #define NET_TOOLS_FLIP_SERVER_SPDY_UTIL_H_	6 #define NET_TOOLS_FLIP_SERVER_SPDY_UTIL_H_

7	7

8 #include <string>	8 #include <string>

9	9

10 namespace net {	10 namespace net {

11	11

12 // Flag indicating if we need to encode urls into filenames (legacy).	12 // Flag indicating if we need to encode urls into filenames (legacy).

13 extern bool g_need_to_encode_url;	13 extern bool g_need_to_encode_url;

14	14

15 // Encode the URL.	15 // Encode the URL.

16 std::string EncodeURL(std::string uri, std::string host, std::string method);	16 std::string EncodeURL(const std::string& uri,

	17 const std::string& host,

	18 const std::string& method);

17	19

18 } // namespace net	20 } // namespace net

19	21

20 #endif // NET_TOOLS_FLIP_SERVER_SPDY_UTIL_H_	22 #endif // NET_TOOLS_FLIP_SERVER_SPDY_UTIL_H_

OLD	NEW

« no previous file with comments | « net/test/embedded_test_server/tcp_listen_socket_unittest.h ('k') | net/tools/flip_server/spdy_util.cc » ('j') | url/gurl.h » ('J')