Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Side by Side Diff: net/quic/crypto/crypto_server_config_protobuf.h

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_QUIC_CRYPTO_CRYPTO_SERVER_CONFIG_PROTOBUF_H_ 5 #ifndef NET_QUIC_CRYPTO_CRYPTO_SERVER_CONFIG_PROTOBUF_H_
6 #define NET_QUIC_CRYPTO_CRYPTO_SERVER_CONFIG_PROTOBUF_H_ 6 #define NET_QUIC_CRYPTO_CRYPTO_SERVER_CONFIG_PROTOBUF_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 17 matching lines...) Expand all
28 public: 28 public:
29 QuicTag tag() const { 29 QuicTag tag() const {
30 return tag_; 30 return tag_;
31 } 31 }
32 void set_tag(QuicTag tag) { 32 void set_tag(QuicTag tag) {
33 tag_ = tag; 33 tag_ = tag;
34 } 34 }
35 std::string private_key() const { 35 std::string private_key() const {
36 return private_key_; 36 return private_key_;
37 } 37 }
38 void set_private_key(std::string key) { 38 void set_private_key(const std::string& key) { private_key_ = key; }
39 private_key_ = key;
40 }
41 39
42 private: 40 private:
43 QuicTag tag_; 41 QuicTag tag_;
44 std::string private_key_; 42 std::string private_key_;
45 }; 43 };
46 44
47 QuicServerConfigProtobuf(); 45 QuicServerConfigProtobuf();
48 ~QuicServerConfigProtobuf(); 46 ~QuicServerConfigProtobuf();
49 47
50 size_t key_size() const { 48 size_t key_size() const {
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
130 // tokens when talking to clients that select this server config. 128 // tokens when talking to clients that select this server config.
131 // It can be of any length as it is fed into a KDF before use. 129 // It can be of any length as it is fed into a KDF before use.
132 std::string source_address_token_secret_override_; 130 std::string source_address_token_secret_override_;
133 131
134 DISALLOW_COPY_AND_ASSIGN(QuicServerConfigProtobuf); 132 DISALLOW_COPY_AND_ASSIGN(QuicServerConfigProtobuf);
135 }; 133 };
136 134
137 } // namespace net 135 } // namespace net
138 136
139 #endif // NET_QUIC_CRYPTO_CRYPTO_SERVER_CONFIG_PROTOBUF_H_ 137 #endif // NET_QUIC_CRYPTO_CRYPTO_SERVER_CONFIG_PROTOBUF_H_
OLDNEW
« no previous file with comments | « net/http/http_cache_unittest.cc ('k') | net/quic/quic_stream_sequencer.h » ('j') | url/gurl.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698