Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Side by Side Diff: google_apis/gcm/monitoring/gcm_stats_recorder.h

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef GOOGLE_APIS_GCM_MONITORING_GCM_STATS_RECORDER_H_ 5 #ifndef GOOGLE_APIS_GCM_MONITORING_GCM_STATS_RECORDER_H_
6 #define GOOGLE_APIS_GCM_MONITORING_GCM_STATS_RECORDER_H_ 6 #define GOOGLE_APIS_GCM_MONITORING_GCM_STATS_RECORDER_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 virtual void RecordCheckinInitiated(uint64 android_id) = 0; 45 virtual void RecordCheckinInitiated(uint64 android_id) = 0;
46 46
47 // Records that a check-in has been delayed due to backoff. 47 // Records that a check-in has been delayed due to backoff.
48 virtual void RecordCheckinDelayedDueToBackoff(int64 delay_msec) = 0; 48 virtual void RecordCheckinDelayedDueToBackoff(int64 delay_msec) = 0;
49 49
50 // Records that a check-in request has succeeded. 50 // Records that a check-in request has succeeded.
51 virtual void RecordCheckinSuccess() = 0; 51 virtual void RecordCheckinSuccess() = 0;
52 52
53 // Records that a check-in request has failed. If a retry will be tempted then 53 // Records that a check-in request has failed. If a retry will be tempted then
54 // will_retry should be true. 54 // will_retry should be true.
55 virtual void RecordCheckinFailure(std::string status, bool will_retry) = 0; 55 virtual void RecordCheckinFailure(const std::string& status,
56 bool will_retry) = 0;
56 57
57 // Records that a connection to MCS has been initiated. 58 // Records that a connection to MCS has been initiated.
58 virtual void RecordConnectionInitiated(const std::string& host) = 0; 59 virtual void RecordConnectionInitiated(const std::string& host) = 0;
59 60
60 // Records that a connection has been delayed due to backoff. 61 // Records that a connection has been delayed due to backoff.
61 virtual void RecordConnectionDelayedDueToBackoff(int64 delay_msec) = 0; 62 virtual void RecordConnectionDelayedDueToBackoff(int64 delay_msec) = 0;
62 63
63 // Records that connection has been successfully established. 64 // Records that connection has been successfully established.
64 virtual void RecordConnectionSuccess() = 0; 65 virtual void RecordConnectionSuccess() = 0;
65 66
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 int ttl) = 0; 132 int ttl) = 0;
132 // Records that a 'send error' message was received. 133 // Records that a 'send error' message was received.
133 virtual void RecordIncomingSendError(const std::string& app_id, 134 virtual void RecordIncomingSendError(const std::string& app_id,
134 const std::string& receiver_id, 135 const std::string& receiver_id,
135 const std::string& message_id) = 0; 136 const std::string& message_id) = 0;
136 }; 137 };
137 138
138 } // namespace gcm 139 } // namespace gcm
139 140
140 #endif // GOOGLE_APIS_GCM_MONITORING_GCM_STATS_RECORDER_H_ 141 #endif // GOOGLE_APIS_GCM_MONITORING_GCM_STATS_RECORDER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698