Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Side by Side Diff: chromeos/dbus/fake_shill_manager_client.h

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROMEOS_DBUS_FAKE_SHILL_MANAGER_CLIENT_H_ 5 #ifndef CHROMEOS_DBUS_FAKE_SHILL_MANAGER_CLIENT_H_
6 #define CHROMEOS_DBUS_FAKE_SHILL_MANAGER_CLIENT_H_ 6 #define CHROMEOS_DBUS_FAKE_SHILL_MANAGER_CLIENT_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
119 base::ListValue* GetEnabledServiceList(const std::string& property) const; 119 base::ListValue* GetEnabledServiceList(const std::string& property) const;
120 void ScanCompleted(const std::string& device_path, 120 void ScanCompleted(const std::string& device_path,
121 const base::Closure& callback); 121 const base::Closure& callback);
122 122
123 // Parses the command line for Shill stub switches and sets initial states. 123 // Parses the command line for Shill stub switches and sets initial states.
124 // Uses comma-separated name-value pairs (see SplitStringIntoKeyValuePairs): 124 // Uses comma-separated name-value pairs (see SplitStringIntoKeyValuePairs):
125 // interactive={delay} - sets delay in seconds for interactive UI 125 // interactive={delay} - sets delay in seconds for interactive UI
126 // {wifi,cellular,etc}={on,off,disabled,none} - sets initial state for type 126 // {wifi,cellular,etc}={on,off,disabled,none} - sets initial state for type
127 void ParseCommandLineSwitch(); 127 void ParseCommandLineSwitch();
128 bool ParseOption(const std::string& arg0, const std::string& arg1); 128 bool ParseOption(const std::string& arg0, const std::string& arg1);
129 bool SetInitialNetworkState(std::string type_arg, std::string state_arg); 129 bool SetInitialNetworkState(const std::string& type_arg,
130 const std::string& state_arg);
130 std::string GetInitialStateForType(const std::string& type, 131 std::string GetInitialStateForType(const std::string& type,
131 bool* enabled); 132 bool* enabled);
132 133
133 // Dictionary of property name -> property value 134 // Dictionary of property name -> property value
134 base::DictionaryValue stub_properties_; 135 base::DictionaryValue stub_properties_;
135 136
136 // Dictionary of technology -> list of property dictionaries 137 // Dictionary of technology -> list of property dictionaries
137 base::DictionaryValue stub_geo_networks_; 138 base::DictionaryValue stub_geo_networks_;
138 139
139 // Seconds to delay interactive actions 140 // Seconds to delay interactive actions
(...skipping 23 matching lines...) Expand all
163 // Note: This should remain the last member so it'll be destroyed and 164 // Note: This should remain the last member so it'll be destroyed and
164 // invalidate its weak pointers before any other members are destroyed. 165 // invalidate its weak pointers before any other members are destroyed.
165 base::WeakPtrFactory<FakeShillManagerClient> weak_ptr_factory_; 166 base::WeakPtrFactory<FakeShillManagerClient> weak_ptr_factory_;
166 167
167 DISALLOW_COPY_AND_ASSIGN(FakeShillManagerClient); 168 DISALLOW_COPY_AND_ASSIGN(FakeShillManagerClient);
168 }; 169 };
169 170
170 } // namespace chromeos 171 } // namespace chromeos
171 172
172 #endif // CHROMEOS_DBUS_FAKE_SHILL_MANAGER_CLIENT_H_ 173 #endif // CHROMEOS_DBUS_FAKE_SHILL_MANAGER_CLIENT_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698