chrome_elf/dll_hash/dll_hash.cc - Issue 1349783006: Cleanup: Pass std::string as const reference if possible

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome_elf/dll_hash/dll_hash.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert third_party changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/hash.h"	5 #include "base/hash.h"

6 #include "chrome_elf/dll_hash/dll_hash.h"	6 #include "chrome_elf/dll_hash/dll_hash.h"

7	7

8 int DllNameToHash(std::string dll_name) {	8 int DllNameToHash(const std::string& dll_name) {

9 uint32 data = base::Hash(dll_name);	9 uint32 data = base::Hash(dll_name);

10	10

11 // Strip off the signed bit because UMA doesn't support negative values,	11 // Strip off the signed bit because UMA doesn't support negative values,

12 // but takes a signed int as input.	12 // but takes a signed int as input.

13 return static_cast<int>(data & 0x7fffffff);	13 return static_cast<int>(data & 0x7fffffff);

14 }	14 }

OLD	NEW

« no previous file with comments | « chrome_elf/dll_hash/dll_hash.h ('k') | chromecast/media/cma/backend/audio_video_pipeline_device_unittest.cc » ('j') | url/gurl.h » ('J')