Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Side by Side Diff: chrome/browser/media_galleries/media_galleries_scan_result_controller.h

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_MEDIA_GALLERIES_MEDIA_GALLERIES_SCAN_RESULT_CONTROLLER_H_ 5 #ifndef CHROME_BROWSER_MEDIA_GALLERIES_MEDIA_GALLERIES_SCAN_RESULT_CONTROLLER_H_
6 #define CHROME_BROWSER_MEDIA_GALLERIES_MEDIA_GALLERIES_SCAN_RESULT_CONTROLLER_H_ 6 #define CHROME_BROWSER_MEDIA_GALLERIES_MEDIA_GALLERIES_SCAN_RESULT_CONTROLLER_H_
7 7
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <string> 10 #include <string>
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
95 friend class MediaGalleriesScanResultCocoaTest; 95 friend class MediaGalleriesScanResultCocoaTest;
96 friend class TestMediaGalleriesAddScanResultsFunction; 96 friend class TestMediaGalleriesAddScanResultsFunction;
97 97
98 // Bottom half of constructor -- called when |preferences_| is initialized. 98 // Bottom half of constructor -- called when |preferences_| is initialized.
99 void OnPreferencesInitialized(); 99 void OnPreferencesInitialized();
100 100
101 // Used to keep the dialog in sync with the preferences. 101 // Used to keep the dialog in sync with the preferences.
102 void OnPreferenceUpdate(const std::string& extension_id); 102 void OnPreferenceUpdate(const std::string& extension_id);
103 103
104 // Used to keep the dialog in sync with attached and detached devices. 104 // Used to keep the dialog in sync with attached and detached devices.
105 void OnRemovableDeviceUpdate(const std::string device_id); 105 void OnRemovableDeviceUpdate(const std::string& device_id);
106 106
107 Profile* GetProfile() const; 107 Profile* GetProfile() const;
108 108
109 // RemovableStorageObserver implementation. 109 // RemovableStorageObserver implementation.
110 // Used to keep dialog in sync with removable device status. 110 // Used to keep dialog in sync with removable device status.
111 void OnRemovableStorageAttached( 111 void OnRemovableStorageAttached(
112 const storage_monitor::StorageInfo& info) override; 112 const storage_monitor::StorageInfo& info) override;
113 void OnRemovableStorageDetached( 113 void OnRemovableStorageDetached(
114 const storage_monitor::StorageInfo& info) override; 114 const storage_monitor::StorageInfo& info) override;
115 115
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
155 155
156 // The view that's showing. 156 // The view that's showing.
157 scoped_ptr<MediaGalleriesDialog> dialog_; 157 scoped_ptr<MediaGalleriesDialog> dialog_;
158 158
159 scoped_ptr<MediaGalleryContextMenu> context_menu_; 159 scoped_ptr<MediaGalleryContextMenu> context_menu_;
160 160
161 DISALLOW_COPY_AND_ASSIGN(MediaGalleriesScanResultController); 161 DISALLOW_COPY_AND_ASSIGN(MediaGalleriesScanResultController);
162 }; 162 };
163 163
164 #endif // CHROME_BROWSER_MEDIA_GALLERIES_MEDIA_GALLERIES_SCAN_RESULT_CONTROLLER _H_ 164 #endif // CHROME_BROWSER_MEDIA_GALLERIES_MEDIA_GALLERIES_SCAN_RESULT_CONTROLLER _H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698