Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(860)

Side by Side Diff: chrome/browser/media/webrtc_browsertest_base.h

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_MEDIA_WEBRTC_BROWSERTEST_BASE_H_ 5 #ifndef CHROME_BROWSER_MEDIA_WEBRTC_BROWSERTEST_BASE_H_
6 #define CHROME_BROWSER_MEDIA_WEBRTC_BROWSERTEST_BASE_H_ 6 #define CHROME_BROWSER_MEDIA_WEBRTC_BROWSERTEST_BASE_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "chrome/test/base/in_process_browser_test.h" 10 #include "chrome/test/base/in_process_browser_test.h"
(...skipping 123 matching lines...) Expand 10 before | Expand all | Expand 10 after
134 // Returns true if we're on win 8. 134 // Returns true if we're on win 8.
135 bool OnWin8() const; 135 bool OnWin8() const;
136 136
137 private: 137 private:
138 void CloseInfoBarInTab(content::WebContents* tab_contents, 138 void CloseInfoBarInTab(content::WebContents* tab_contents,
139 infobars::InfoBar* infobar) const; 139 infobars::InfoBar* infobar) const;
140 140
141 std::string CreateLocalOffer(content::WebContents* from_tab) const; 141 std::string CreateLocalOffer(content::WebContents* from_tab) const;
142 std::string CreateAnswer(std::string local_offer, 142 std::string CreateAnswer(std::string local_offer,
143 content::WebContents* to_tab) const; 143 content::WebContents* to_tab) const;
144 void ReceiveAnswer(std::string answer, content::WebContents* from_tab) const; 144 void ReceiveAnswer(const std::string& answer,
145 content::WebContents* from_tab) const;
145 void GatherAndSendIceCandidates(content::WebContents* from_tab, 146 void GatherAndSendIceCandidates(content::WebContents* from_tab,
146 content::WebContents* to_tab) const; 147 content::WebContents* to_tab) const;
147 148
148 infobars::InfoBar* GetUserMediaAndWaitForInfoBar( 149 infobars::InfoBar* GetUserMediaAndWaitForInfoBar(
149 content::WebContents* tab_contents, 150 content::WebContents* tab_contents,
150 const std::string& constraints) const; 151 const std::string& constraints) const;
151 152
152 bool detect_errors_in_javascript_; 153 bool detect_errors_in_javascript_;
153 154
154 DISALLOW_COPY_AND_ASSIGN(WebRtcTestBase); 155 DISALLOW_COPY_AND_ASSIGN(WebRtcTestBase);
155 }; 156 };
156 157
157 #endif // CHROME_BROWSER_MEDIA_WEBRTC_BROWSERTEST_BASE_H_ 158 #endif // CHROME_BROWSER_MEDIA_WEBRTC_BROWSERTEST_BASE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698