Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Side by Side Diff: chrome/browser/extensions/extension_message_bubble_controller.h

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_MESSAGE_BUBBLE_CONTROLLER_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_MESSAGE_BUBBLE_CONTROLLER_H_
6 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_MESSAGE_BUBBLE_CONTROLLER_H_ 6 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_MESSAGE_BUBBLE_CONTROLLER_H_
7 7
8 #include <string> 8 #include <string>
9 #include "chrome/browser/extensions/extension_message_bubble.h" 9 #include "chrome/browser/extensions/extension_message_bubble.h"
10 #include "extensions/browser/browser_context_keyed_api_factory.h" 10 #include "extensions/browser/browser_context_keyed_api_factory.h"
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
77 virtual bool HasBubbleInfoBeenAcknowledged(const std::string& extension_id); 77 virtual bool HasBubbleInfoBeenAcknowledged(const std::string& extension_id);
78 virtual void SetBubbleInfoBeenAcknowledged(const std::string& extension_id, 78 virtual void SetBubbleInfoBeenAcknowledged(const std::string& extension_id,
79 bool value); 79 bool value);
80 80
81 protected: 81 protected:
82 Profile* profile() { return profile_; } 82 Profile* profile() { return profile_; }
83 ExtensionService* service() { return service_; } 83 ExtensionService* service() { return service_; }
84 const ExtensionRegistry* registry() const { return registry_; } 84 const ExtensionRegistry* registry() const { return registry_; }
85 85
86 std::string get_acknowledged_flag_pref_name() const; 86 std::string get_acknowledged_flag_pref_name() const;
87 void set_acknowledged_flag_pref_name(std::string pref_name); 87 void set_acknowledged_flag_pref_name(const std::string& pref_name);
88 88
89 private: 89 private:
90 // A weak pointer to the profile we are associated with. Not owned by us. 90 // A weak pointer to the profile we are associated with. Not owned by us.
91 Profile* profile_; 91 Profile* profile_;
92 92
93 // The extension service associated with the profile. 93 // The extension service associated with the profile.
94 ExtensionService* service_; 94 ExtensionService* service_;
95 95
96 // The extension registry associated with the profile. 96 // The extension registry associated with the profile.
97 ExtensionRegistry* registry_; 97 ExtensionRegistry* registry_;
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
165 165
166 // Whether or not the bubble is highlighting extensions. 166 // Whether or not the bubble is highlighting extensions.
167 bool did_highlight_; 167 bool did_highlight_;
168 168
169 DISALLOW_COPY_AND_ASSIGN(ExtensionMessageBubbleController); 169 DISALLOW_COPY_AND_ASSIGN(ExtensionMessageBubbleController);
170 }; 170 };
171 171
172 } // namespace extensions 172 } // namespace extensions
173 173
174 #endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_MESSAGE_BUBBLE_CONTROLLER_H_ 174 #endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_MESSAGE_BUBBLE_CONTROLLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698