Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Side by Side Diff: chrome/browser/extensions/extension_message_bubble_controller.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/extension_message_bubble_controller.h" 5 #include "chrome/browser/extensions/extension_message_bubble_controller.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/metrics/histogram.h" 8 #include "base/metrics/histogram.h"
9 #include "base/strings/string_number_conversions.h" 9 #include "base/strings/string_number_conversions.h"
10 #include "base/strings/string_util.h" 10 #include "base/strings/string_util.h"
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 pref_name, 76 pref_name,
77 value ? new base::FundamentalValue(value) : NULL); 77 value ? new base::FundamentalValue(value) : NULL);
78 } 78 }
79 79
80 std::string 80 std::string
81 ExtensionMessageBubbleController::Delegate::get_acknowledged_flag_pref_name() 81 ExtensionMessageBubbleController::Delegate::get_acknowledged_flag_pref_name()
82 const { 82 const {
83 return acknowledged_pref_name_; 83 return acknowledged_pref_name_;
84 } 84 }
85 85
86 void 86 void ExtensionMessageBubbleController::Delegate::
87 ExtensionMessageBubbleController::Delegate::set_acknowledged_flag_pref_name( 87 set_acknowledged_flag_pref_name(const std::string& pref_name) {
88 std::string pref_name) {
89 acknowledged_pref_name_ = pref_name; 88 acknowledged_pref_name_ = pref_name;
90 } 89 }
91 90
92 //////////////////////////////////////////////////////////////////////////////// 91 ////////////////////////////////////////////////////////////////////////////////
93 // ExtensionMessageBubbleController 92 // ExtensionMessageBubbleController
94 93
95 ExtensionMessageBubbleController::ExtensionMessageBubbleController( 94 ExtensionMessageBubbleController::ExtensionMessageBubbleController(
96 Delegate* delegate, 95 Delegate* delegate,
97 Browser* browser) 96 Browser* browser)
98 : browser_(browser), 97 : browser_(browser),
(...skipping 146 matching lines...) Expand 10 before | Expand all | Expand 10 after
245 return &extension_list_; 244 return &extension_list_;
246 } 245 }
247 246
248 void ExtensionMessageBubbleController::OnClose() { 247 void ExtensionMessageBubbleController::OnClose() {
249 AcknowledgeExtensions(); 248 AcknowledgeExtensions();
250 if (did_highlight_) 249 if (did_highlight_)
251 ToolbarActionsModel::Get(profile())->StopHighlighting(); 250 ToolbarActionsModel::Get(profile())->StopHighlighting();
252 } 251 }
253 252
254 } // namespace extensions 253 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698