Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1340)

Side by Side Diff: chrome/browser/chromeos/login/screens/hid_detection_screen.h

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_CHROMEOS_LOGIN_SCREENS_HID_DETECTION_SCREEN_H_ 5 #ifndef CHROME_BROWSER_CHROMEOS_LOGIN_SCREENS_HID_DETECTION_SCREEN_H_
6 #define CHROME_BROWSER_CHROMEOS_LOGIN_SCREENS_HID_DETECTION_SCREEN_H_ 6 #define CHROME_BROWSER_CHROMEOS_LOGIN_SCREENS_HID_DETECTION_SCREEN_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 156 matching lines...) Expand 10 before | Expand all | Expand 10 after
167 167
168 // Sends a notification to the Web UI of the status of available Bluetooth/USB 168 // Sends a notification to the Web UI of the status of available Bluetooth/USB
169 // pointing device. 169 // pointing device.
170 void SendPointingDeviceNotification(); 170 void SendPointingDeviceNotification();
171 171
172 // Sends a notification to the Web UI of the status of available Bluetooth/USB 172 // Sends a notification to the Web UI of the status of available Bluetooth/USB
173 // keyboard device. 173 // keyboard device.
174 void SendKeyboardDeviceNotification(); 174 void SendKeyboardDeviceNotification();
175 175
176 // Helper method. Sets device name or placeholder if the name is empty. 176 // Helper method. Sets device name or placeholder if the name is empty.
177 void SetKeyboardDeviceName_(std::string name); 177 void SetKeyboardDeviceName_(const std::string& name);
178
179 178
180 HIDDetectionView* view_; 179 HIDDetectionView* view_;
181 180
182 // Default bluetooth adapter, used for all operations. 181 // Default bluetooth adapter, used for all operations.
183 scoped_refptr<device::BluetoothAdapter> adapter_; 182 scoped_refptr<device::BluetoothAdapter> adapter_;
184 183
185 InputServiceProxy input_service_proxy_; 184 InputServiceProxy input_service_proxy_;
186 185
187 // The current device discovery session. Only one active discovery session is 186 // The current device discovery session. Only one active discovery session is
188 // kept at a time and the instance that |discovery_session_| points to gets 187 // kept at a time and the instance that |discovery_session_| points to gets
(...skipping 19 matching lines...) Expand all
208 bool showing_; 207 bool showing_;
209 208
210 base::WeakPtrFactory<HIDDetectionScreen> weak_ptr_factory_; 209 base::WeakPtrFactory<HIDDetectionScreen> weak_ptr_factory_;
211 210
212 DISALLOW_COPY_AND_ASSIGN(HIDDetectionScreen); 211 DISALLOW_COPY_AND_ASSIGN(HIDDetectionScreen);
213 }; 212 };
214 213
215 } // namespace chromeos 214 } // namespace chromeos
216 215
217 #endif // CHROME_BROWSER_CHROMEOS_LOGIN_SCREENS_HID_DETECTION_SCREEN_H_ 216 #endif // CHROME_BROWSER_CHROMEOS_LOGIN_SCREENS_HID_DETECTION_SCREEN_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698