Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Side by Side Diff: chrome/browser/chromeos/input_method/input_method_manager_impl.h

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_CHROMEOS_INPUT_METHOD_INPUT_METHOD_MANAGER_IMPL_H_ 5 #ifndef CHROME_BROWSER_CHROMEOS_INPUT_METHOD_INPUT_METHOD_MANAGER_IMPL_H_
6 #define CHROME_BROWSER_CHROMEOS_INPUT_METHOD_INPUT_METHOD_MANAGER_IMPL_H_ 6 #define CHROME_BROWSER_CHROMEOS_INPUT_METHOD_INPUT_METHOD_MANAGER_IMPL_H_
7 7
8 #include <map> 8 #include <map>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 203 matching lines...) Expand 10 before | Expand all | Expand 10 after
214 // Loads necessary component extensions. 214 // Loads necessary component extensions.
215 // TODO(nona): Support dynamical unloading. 215 // TODO(nona): Support dynamical unloading.
216 void LoadNecessaryComponentExtensions(StateImpl* state); 216 void LoadNecessaryComponentExtensions(StateImpl* state);
217 217
218 // Starts or stops the system input method framework as needed. 218 // Starts or stops the system input method framework as needed.
219 // (after list of enabled input methods has been updated). 219 // (after list of enabled input methods has been updated).
220 // If state is active, active input method is updated. 220 // If state is active, active input method is updated.
221 void ReconfigureIMFramework(StateImpl* state); 221 void ReconfigureIMFramework(StateImpl* state);
222 222
223 // Record input method usage histograms. 223 // Record input method usage histograms.
224 void RecordInputMethodUsage(std::string input_method_id); 224 void RecordInputMethodUsage(const std::string& input_method_id);
225 225
226 scoped_ptr<InputMethodDelegate> delegate_; 226 scoped_ptr<InputMethodDelegate> delegate_;
227 227
228 // The current UI session status. 228 // The current UI session status.
229 UISessionState ui_session_; 229 UISessionState ui_session_;
230 230
231 // A list of objects that monitor the manager. 231 // A list of objects that monitor the manager.
232 base::ObserverList<InputMethodManager::Observer> observers_; 232 base::ObserverList<InputMethodManager::Observer> observers_;
233 base::ObserverList<CandidateWindowObserver> candidate_window_observers_; 233 base::ObserverList<CandidateWindowObserver> candidate_window_observers_;
234 234
(...skipping 23 matching lines...) Expand all
258 typedef std::map<Profile*, EngineMap, ProfileCompare> ProfileEngineMap; 258 typedef std::map<Profile*, EngineMap, ProfileCompare> ProfileEngineMap;
259 ProfileEngineMap engine_map_; 259 ProfileEngineMap engine_map_;
260 260
261 DISALLOW_COPY_AND_ASSIGN(InputMethodManagerImpl); 261 DISALLOW_COPY_AND_ASSIGN(InputMethodManagerImpl);
262 }; 262 };
263 263
264 } // namespace input_method 264 } // namespace input_method
265 } // namespace chromeos 265 } // namespace chromeos
266 266
267 #endif // CHROME_BROWSER_CHROMEOS_INPUT_METHOD_INPUT_METHOD_MANAGER_IMPL_H_ 267 #endif // CHROME_BROWSER_CHROMEOS_INPUT_METHOD_INPUT_METHOD_MANAGER_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698