Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 13497009: Remove ENABLE(FILE_SYSTEM) compile-time flag. (Closed)

Created:
7 years, 8 months ago by kinuko
Modified:
7 years, 8 months ago
Reviewers:
tkent
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, jsbell, alecflett, yurys+blink_chromium.org, abarth-chromium, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dgrogan, haraken, Nate Chapin, tzik
Visibility:
Public.

Description

Remove ENABLE(FILE_SYSTEM) compile-time flag. This is enabled and supported on all Chromium platforms. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=147806 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=147811

Patch Set 1 : #

Total comments: 4

Patch Set 2 : addressed comments #

Patch Set 3 : added CodeGeneratorInspector.py change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -538 lines) Patch
M LayoutTests/fast/dom/MutationObserver/filesystem-callback-delivery.html View 1 chunk +1 line, -5 lines 0 comments Download
M Source/WTF/wtf/FeatureDefines.h View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/filesystem/AsyncFileWriter.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/filesystem/AsyncFileWriterClient.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/filesystem/DOMFilePath.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/filesystem/DOMFilePath.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/filesystem/DOMFileSystem.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/filesystem/DOMFileSystem.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/filesystem/DOMFileSystem.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/Modules/filesystem/DOMFileSystemBase.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/filesystem/DOMFileSystemBase.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/filesystem/DOMFileSystemSync.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/filesystem/DOMFileSystemSync.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/filesystem/DOMFileSystemSync.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/WebCore/Modules/filesystem/DOMWindowFileSystem.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/filesystem/DOMWindowFileSystem.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/filesystem/DOMWindowFileSystem.idl View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/Modules/filesystem/DataTransferItemFileSystem.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/filesystem/DataTransferItemFileSystem.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/Modules/filesystem/DirectoryEntry.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/filesystem/DirectoryEntry.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/filesystem/DirectoryEntry.idl View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M Source/WebCore/Modules/filesystem/DirectoryEntrySync.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/filesystem/DirectoryEntrySync.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/filesystem/DirectoryEntrySync.idl View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M Source/WebCore/Modules/filesystem/DirectoryReader.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/filesystem/DirectoryReader.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/filesystem/DirectoryReader.idl View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/Modules/filesystem/DirectoryReaderBase.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/filesystem/DirectoryReaderSync.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/filesystem/DirectoryReaderSync.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/filesystem/DirectoryReaderSync.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/Modules/filesystem/EntriesCallback.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/filesystem/EntriesCallback.idl View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/Modules/filesystem/Entry.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/filesystem/Entry.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/filesystem/Entry.idl View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/Modules/filesystem/EntryArray.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/filesystem/EntryArray.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/filesystem/EntryArray.idl View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/Modules/filesystem/EntryArraySync.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/filesystem/EntryArraySync.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/filesystem/EntryArraySync.idl View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/Modules/filesystem/EntryBase.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/filesystem/EntryBase.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/filesystem/EntryCallback.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/filesystem/EntryCallback.idl View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/Modules/filesystem/EntrySync.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/filesystem/EntrySync.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/filesystem/EntrySync.idl View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/Modules/filesystem/ErrorCallback.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/filesystem/ErrorCallback.idl View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/Modules/filesystem/FileCallback.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/filesystem/FileCallback.idl View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/Modules/filesystem/FileEntry.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/filesystem/FileEntry.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/filesystem/FileEntry.idl View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M Source/WebCore/Modules/filesystem/FileEntrySync.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/filesystem/FileEntrySync.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/filesystem/FileEntrySync.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/WebCore/Modules/filesystem/FileSystemCallback.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/filesystem/FileSystemCallback.idl View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/Modules/filesystem/FileSystemCallbacks.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/filesystem/FileSystemCallbacks.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/filesystem/FileSystemFlags.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/filesystem/FileSystemType.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/filesystem/FileWriter.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/filesystem/FileWriter.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/filesystem/FileWriter.idl View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/Modules/filesystem/FileWriterBase.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/filesystem/FileWriterBase.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/filesystem/FileWriterBaseCallback.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/filesystem/FileWriterCallback.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/filesystem/FileWriterCallback.idl View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/Modules/filesystem/FileWriterSync.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/filesystem/FileWriterSync.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/filesystem/FileWriterSync.idl View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M Source/WebCore/Modules/filesystem/HTMLInputElementFileSystem.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/filesystem/HTMLInputElementFileSystem.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/Modules/filesystem/LocalFileSystem.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/filesystem/LocalFileSystem.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/filesystem/Metadata.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/filesystem/Metadata.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/Modules/filesystem/MetadataCallback.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/filesystem/MetadataCallback.idl View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/Modules/filesystem/SyncCallbackHelper.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/filesystem/WorkerContextFileSystem.h View 2 chunks +1 line, -5 lines 0 comments Download
M Source/WebCore/Modules/filesystem/WorkerContextFileSystem.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/filesystem/WorkerContextFileSystem.idl View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/Modules/filesystem/chromium/DOMFileSystemChromium.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/filesystem/chromium/DataTransferItemFileSystemChromium.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/filesystem/chromium/DraggedIsolatedFileSystem.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/filesystem/chromium/DraggedIsolatedFileSystem.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp View 1 2 2 chunks +1 line, -6 lines 0 comments Download
M Source/WebCore/bindings/v8/SerializedScriptValue.cpp View 11 chunks +1 line, -16 lines 0 comments Download
M Source/WebCore/bindings/v8/custom/V8EntryCustom.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/bindings/v8/custom/V8EntrySyncCustom.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/dom/EventTargetFactory.in View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/fileapi/Blob.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M Source/WebCore/fileapi/File.h View 3 chunks +0 lines, -7 lines 0 comments Download
M Source/WebCore/fileapi/File.cpp View 7 chunks +0 lines, -16 lines 0 comments Download
M Source/WebCore/fileapi/FileError.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/fileapi/FileException.idl View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/fileapi/WebKitBlobBuilder.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M Source/WebCore/html/FileInputType.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/html/FileInputType.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/html/HTMLInputElement.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/html/HTMLInputElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/html/InputType.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/html/InputType.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/CodeGeneratorInspector.py View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/inspector/InspectorController.cpp View 1 2 2 chunks +1 line, -3 lines 0 comments Download
M Source/WebCore/inspector/InspectorFileSystemAgent.h View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/WebCore/inspector/InspectorFileSystemAgent.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/inspector/InspectorFrontendHost.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/InspectorFrontendHost.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/WebCore/inspector/InspectorFrontendHost.idl View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/inspector/InstrumentingAgents.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/inspector/InstrumentingAgents.cpp View 3 chunks +0 lines, -5 lines 0 comments Download
M Source/WebCore/page/DOMWindow.idl View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/page/SecurityOrigin.cpp View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/platform/AsyncFileSystem.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/platform/AsyncFileSystem.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/platform/AsyncFileSystemCallbacks.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/platform/DragData.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/platform/FileMetadata.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/WebCore/platform/SchemeRegistry.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/platform/chromium/DragDataChromium.cpp View 4 chunks +1 line, -7 lines 0 comments Download
M Source/WebCore/platform/chromium/MIMETypeRegistryChromium.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/platform/chromium/support/WebHTTPBody.cpp View 3 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/platform/network/BlobData.h View 4 chunks +2 lines, -8 lines 0 comments Download
M Source/WebCore/platform/network/BlobData.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/platform/network/BlobRegistryImpl.cpp View 3 chunks +0 lines, -6 lines 0 comments Download
M Source/WebCore/platform/network/FormData.h View 4 chunks +0 lines, -8 lines 0 comments Download
M Source/WebCore/platform/network/FormData.cpp View 7 chunks +0 lines, -12 lines 0 comments Download
M Source/WebKit/chromium/features.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebKit/chromium/src/AssertMatchingEnums.cpp View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebKit/chromium/src/AsyncFileSystemChromium.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebKit/chromium/src/AsyncFileSystemChromium.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebKit/chromium/src/AsyncFileWriterChromium.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebKit/chromium/src/AsyncFileWriterChromium.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebKit/chromium/src/LocalFileSystemChromium.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebKit/chromium/src/WebDragData.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/WebKit/chromium/src/WebFileSystemCallbacksImpl.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebKit/chromium/src/WebRuntimeFeatures.cpp View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M Source/WebKit/chromium/src/WorkerAsyncFileSystemChromium.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/WebKit/chromium/src/WorkerAsyncFileSystemChromium.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/WebKit/chromium/src/WorkerAsyncFileWriterChromium.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/WebKit/chromium/src/WorkerAsyncFileWriterChromium.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/WebKit/chromium/src/WorkerFileSystemCallbacksBridge.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebKit/chromium/src/WorkerFileSystemCallbacksBridge.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/WebKit/chromium/src/WorkerFileWriterCallbacksBridge.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebKit/chromium/src/WorkerFileWriterCallbacksBridge.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
kinuko
Kent-san, mind taking a look? Thx,
7 years, 8 months ago (2013-04-08 09:30:05 UTC) #1
tkent
https://codereview.chromium.org/13497009/diff/121/Source/WebCore/fileapi/FileException.idl File Source/WebCore/fileapi/FileException.idl (right): https://codereview.chromium.org/13497009/diff/121/Source/WebCore/fileapi/FileException.idl#newcode32 Source/WebCore/fileapi/FileException.idl:32: Conditional=BLOB, You can remove Conditional like you do in ...
7 years, 8 months ago (2013-04-08 09:41:24 UTC) #2
kinuko
Thx! Updated. https://codereview.chromium.org/13497009/diff/121/Source/WebCore/fileapi/FileException.idl File Source/WebCore/fileapi/FileException.idl (right): https://codereview.chromium.org/13497009/diff/121/Source/WebCore/fileapi/FileException.idl#newcode32 Source/WebCore/fileapi/FileException.idl:32: Conditional=BLOB, On 2013/04/08 09:41:24, Kent Tamura wrote: ...
7 years, 8 months ago (2013-04-08 10:42:32 UTC) #3
tkent
lgtm
7 years, 8 months ago (2013-04-08 10:47:51 UTC) #4
kinuko
Committed patchset #2 manually as r147806 (presubmit successful).
7 years, 8 months ago (2013-04-08 13:32:15 UTC) #5
kinuko
Removed FILE_SYSTEM line from CodeGeneratorInspector.py too: https://codereview.chromium.org/13497009/diff2/8001:13001/Source/WebCore/inspector/CodeGeneratorInspector.py
7 years, 8 months ago (2013-04-08 14:17:59 UTC) #6
kinuko
7 years, 8 months ago (2013-04-08 14:21:10 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 manually as r147811 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698