Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 1349633006: Revert "cc: Don't record first two frames in CompositorTimingHistory" (Closed)

Created:
5 years, 3 months ago by brianderson
Modified:
5 years, 3 months ago
CC:
chromium-reviews, cc-bugs_chromium.org, scheduler-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "cc: Don't record first two frames in CompositorTimingHistory" This reverts commit a79c9467590b3aea6fa41d85f492c7883861537c. BUG=516010 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/d7478de1ae08fa52209afc37ccda6bb5927e6e14 Cr-Commit-Position: refs/heads/master@{#350309}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -142 lines) Patch
M cc/scheduler/compositor_timing_history.h View 1 chunk +0 lines, -3 lines 0 comments Download
M cc/scheduler/compositor_timing_history.cc View 8 chunks +16 lines, -38 lines 0 comments Download
M cc/scheduler/compositor_timing_history_unittest.cc View 5 chunks +2 lines, -97 lines 0 comments Download
M cc/scheduler/scheduler.cc View 4 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
brianderson
5 years, 3 months ago (2015-09-18 22:23:51 UTC) #2
qyearsley
The idea of reverting to check perf consequences LGTM; someone familiar with the code should ...
5 years, 3 months ago (2015-09-21 20:23:44 UTC) #3
sunnyps
LGTM
5 years, 3 months ago (2015-09-21 21:55:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1349633006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1349633006/1
5 years, 3 months ago (2015-09-21 22:15:43 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/43576)
5 years, 3 months ago (2015-09-21 23:18:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1349633006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1349633006/1
5 years, 3 months ago (2015-09-22 23:07:39 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-23 05:58:31 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 05:59:10 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d7478de1ae08fa52209afc37ccda6bb5927e6e14
Cr-Commit-Position: refs/heads/master@{#350309}

Powered by Google App Engine
This is Rietveld 408576698