Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 1349623002: X87: [runtime] Replace the EQUALS builtin with proper Object::Equals. (Closed)

Created:
5 years, 3 months ago by chunyang.dai
Modified:
5 years, 3 months ago
Reviewers:
Weiliang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [runtime] Replace the EQUALS builtin with proper Object::Equals. port 54bab695f5de5bf5948c5b50b217628a00d60f91 (r30747). original commit message: Move the implementation of the Abstract Equality Comparison to the runtime and thereby remove the EQUALS dispatcher builtin. Also remove the various runtime entry points that were only used to support the EQUALS builtin. Now the Abstract Equality Comparison is also using the correct ToPrimitive implementation, which properly supports @@toPrimitive. BUG= Committed: https://crrev.com/e97b1938ddb654646ed59e6628af58114d4619ce Cr-Commit-Position: refs/heads/master@{#30780}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -12 lines) Patch
M src/x87/code-stubs-x87.cc View 1 chunk +8 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
ptal
5 years, 3 months ago (2015-09-16 09:01:10 UTC) #2
Weiliang
lgtm
5 years, 3 months ago (2015-09-17 00:34:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1349623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1349623002/1
5 years, 3 months ago (2015-09-17 00:34:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-17 01:21:51 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 01:22:01 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e97b1938ddb654646ed59e6628af58114d4619ce
Cr-Commit-Position: refs/heads/master@{#30780}

Powered by Google App Engine
This is Rietveld 408576698