extensions/common/manifest_handlers/permissions_parser.h - Issue 1349613003: [Extensions] Un-refcount PermissionSet

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/manifest_handlers/permissions_parser.h

Issue 1349613003: [Extensions] Un-refcount PermissionSet (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/common/manifest_handlers/permissions_parser.h

diff --git a/extensions/common/manifest_handlers/permissions_parser.h b/extensions/common/manifest_handlers/permissions_parser.h

index 81ffe0ec70ee37f1429bdc44072e7d86e6a87485..645017d1b6f469fe0ffb478e7a22441e5aa4538d 100644

--- a/extensions/common/manifest_handlers/permissions_parser.h

+++ b/extensions/common/manifest_handlers/permissions_parser.h

@@ -45,9 +45,9 @@ class PermissionsParser {

// Return the extension's manifest-specified permissions. In no cases should

// these permissions be used to determine if an action is allowed. Instead,

// use PermissionsData.

- static scoped_refptr<const PermissionSet> GetRequiredPermissions(

+ static const PermissionSet* GetRequiredPermissions(

not at google - send to devlin 2015/09/22 21:51:26 (noting place which should be a reference)

const Extension* extension);

- static scoped_refptr<const PermissionSet> GetOptionalPermissions(

+ static const PermissionSet* GetOptionalPermissions(

const Extension* extension);

private: