Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Unified Diff: chrome/browser/ui/sync/profile_signin_confirmation_helper_unittest.cc

Issue 1349613003: [Extensions] Un-refcount PermissionSet (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/sync/profile_signin_confirmation_helper_unittest.cc
diff --git a/chrome/browser/ui/sync/profile_signin_confirmation_helper_unittest.cc b/chrome/browser/ui/sync/profile_signin_confirmation_helper_unittest.cc
index 71dc298e55a18e78ab58ad958a08eea785009131..31e982d3a571ecda7fa0e9e6865aa5bc586ec151 100644
--- a/chrome/browser/ui/sync/profile_signin_confirmation_helper_unittest.cc
+++ b/chrome/browser/ui/sync/profile_signin_confirmation_helper_unittest.cc
@@ -213,16 +213,17 @@ TEST_F(ProfileSigninConfirmationHelperTest, PromptForNewProfile_Extensions) {
CreateExtension("web store",
extensions::kWebStoreAppId,
extensions::Manifest::COMPONENT);
- extensions::ExtensionPrefs::Get(profile_.get())->AddGrantedPermissions(
- webstore->id(), make_scoped_refptr(new extensions::PermissionSet).get());
+ extensions::PermissionSet empty_permissions;
+ extensions::ExtensionPrefs::Get(profile_.get())
+ ->AddGrantedPermissions(webstore->id(), &empty_permissions);
extensions->AddExtension(webstore.get());
EXPECT_FALSE(GetCallbackResult(
base::Bind(&ui::CheckShouldPromptForNewProfile, profile_.get())));
scoped_refptr<extensions::Extension> extension =
CreateExtension("foo", std::string(), extensions::Manifest::INTERNAL);
- extensions::ExtensionPrefs::Get(profile_.get())->AddGrantedPermissions(
- extension->id(), make_scoped_refptr(new extensions::PermissionSet).get());
+ extensions::ExtensionPrefs::Get(profile_.get())
+ ->AddGrantedPermissions(extension->id(), &empty_permissions);
extensions->AddExtension(extension.get());
EXPECT_TRUE(GetCallbackResult(
base::Bind(&ui::CheckShouldPromptForNewProfile, profile_.get())));

Powered by Google App Engine
This is Rietveld 408576698