chrome/browser/extensions/crx_installer_browsertest.cc - Issue 1349613003: [Extensions] Un-refcount PermissionSet

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/crx_installer_browsertest.cc

Issue 1349613003: [Extensions] Un-refcount PermissionSet (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/crx_installer_browsertest.cc

diff --git a/chrome/browser/extensions/crx_installer_browsertest.cc b/chrome/browser/extensions/crx_installer_browsertest.cc

index c6aea6106a4ceb2da19433b472179b0635754948..f01c8f85d9a5714416a07834495201cdbcd8b35f 100644

--- a/chrome/browser/extensions/crx_installer_browsertest.cc

+++ b/chrome/browser/extensions/crx_installer_browsertest.cc

@@ -249,7 +249,7 @@ class ExtensionCrxInstallerTest : public ExtensionBrowserTest {

mock_prompt->set_record_oauth2_grant(record_oauth2_grant);

InstallWithPrompt("browsertest/scopes", std::string(), mock_prompt);

- scoped_refptr<const PermissionSet> permissions =

+ scoped_ptr<const PermissionSet> permissions =

ExtensionPrefs::Get(browser()->profile())

->GetGrantedPermissions(mock_prompt->extension_id());

ASSERT_TRUE(permissions.get());