chrome/browser/extensions/api/developer_private/extension_info_generator.cc - Issue 1349613003: [Extensions] Un-refcount PermissionSet

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/developer_private/extension_info_generator.cc

Issue 1349613003: [Extensions] Un-refcount PermissionSet (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/active_tab_permission_granter.cc ('k') | chrome/browser/extensions/api/permissions/permissions_api.h » ('j') | chrome/browser/extensions/api/permissions/permissions_api_helpers.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/developer_private/extension_info_generator.cc

diff --git a/chrome/browser/extensions/api/developer_private/extension_info_generator.cc b/chrome/browser/extensions/api/developer_private/extension_info_generator.cc

index 316997ca81c6789edcee56bd05e1635d49b513e7..c6f8c606014c1797e9b399175b9d0a657d584484 100644

--- a/chrome/browser/extensions/api/developer_private/extension_info_generator.cc

+++ b/chrome/browser/extensions/api/developer_private/extension_info_generator.cc

@@ -500,8 +500,7 @@ void ExtensionInfoGenerator::CreateExtensionInfoHelper(

info->run_on_all_urls.is_enabled =

(FeatureSwitch::scripts_require_action()->IsEnabled() &&

PermissionsData::ScriptsMayRequireActionForExtension(

- &extension,

- extension.permissions_data()->active_permissions().get())) ||

+ &extension, extension.permissions_data()->active_permissions())) ||

extension.permissions_data()->HasWithheldImpliedAllHosts() ||

util::HasSetAllowedScriptingOnAllUrls(extension.id(), browser_context_);

info->run_on_all_urls.is_active =