Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Unified Diff: extensions/browser/extension_prefs.h

Issue 1349613003: [Extensions] Un-refcount PermissionSet (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/extension_prefs.h
diff --git a/extensions/browser/extension_prefs.h b/extensions/browser/extension_prefs.h
index 924a0171fee39e437b5c78fe8cefb7710ed8252a..0ef1d40a6e33a5575fae1dba8ffd410dd260215b 100644
--- a/extensions/browser/extension_prefs.h
+++ b/extensions/browser/extension_prefs.h
@@ -353,7 +353,7 @@ class ExtensionPrefs : public ExtensionScopedPrefs, public KeyedService {
// Returns the granted permission set for the extension with |extension_id|,
// and NULL if no preferences were found for |extension_id|.
// This passes ownership of the returned set to the caller.
- scoped_refptr<const PermissionSet> GetGrantedPermissions(
+ scoped_ptr<const PermissionSet> GetGrantedPermissions(
const std::string& extension_id) const;
// Adds |permissions| to the granted permissions set for the extension with
@@ -369,7 +369,7 @@ class ExtensionPrefs : public ExtensionScopedPrefs, public KeyedService {
// Gets the active permission set for the specified extension. This may
// differ from the permissions in the manifest due to the optional
// permissions API. This passes ownership of the set to the caller.
- scoped_refptr<const PermissionSet> GetActivePermissions(
+ scoped_ptr<const PermissionSet> GetActivePermissions(
const std::string& extension_id) const;
// Sets the active |permissions| for the extension with |extension_id|.
@@ -605,7 +605,7 @@ class ExtensionPrefs : public ExtensionScopedPrefs, public KeyedService {
// Interprets |pref_key| in |extension_id|'s preferences as an
// PermissionSet, and passes ownership of the set to the caller.
- scoped_refptr<const PermissionSet> ReadPrefAsPermissionSet(
+ scoped_ptr<const PermissionSet> ReadPrefAsPermissionSet(
const std::string& extension_id,
const std::string& pref_key) const;
« no previous file with comments | « chrome/common/extensions/permissions/settings_override_permission_unittest.cc ('k') | extensions/browser/extension_prefs.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698