Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: chrome/browser/extensions/extension_management.cc

Issue 1349613003: [Extensions] Un-refcount PermissionSet (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_management.cc
diff --git a/chrome/browser/extensions/extension_management.cc b/chrome/browser/extensions/extension_management.cc
index 8e801ca8fb03445e8f616439ed6a64d5e0471e3d..202a1bd0be2ac4c99577889a157c7cb46c975370 100644
--- a/chrome/browser/extensions/extension_management.cc
+++ b/chrome/browser/extensions/extension_management.cc
@@ -204,19 +204,19 @@ APIPermissionSet ExtensionManagement::GetBlockedAPIPermissions(
return default_settings_->blocked_permissions;
}
-scoped_refptr<const PermissionSet> ExtensionManagement::GetBlockedPermissions(
+scoped_ptr<const PermissionSet> ExtensionManagement::GetBlockedPermissions(
const Extension* extension) const {
// Only api permissions are supported currently.
- return scoped_refptr<const PermissionSet>(new PermissionSet(
+ return scoped_ptr<const PermissionSet>(new PermissionSet(
GetBlockedAPIPermissions(extension), ManifestPermissionSet(),
URLPatternSet(), URLPatternSet()));
}
bool ExtensionManagement::IsPermissionSetAllowed(
const Extension* extension,
- scoped_refptr<const PermissionSet> perms) const {
+ const PermissionSet& perms) const {
for (const auto& blocked_api : GetBlockedAPIPermissions(extension)) {
- if (perms->HasAPIPermission(blocked_api->id()))
+ if (perms.HasAPIPermission(blocked_api->id()))
return false;
}
return true;
« no previous file with comments | « chrome/browser/extensions/extension_management.h ('k') | chrome/browser/extensions/extension_prefs_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698