chrome/browser/extensions/api/permissions/permissions_api_helpers.h - Issue 1349613003: [Extensions] Un-refcount PermissionSet

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/permissions/permissions_api_helpers.h

Issue 1349613003: [Extensions] Un-refcount PermissionSet (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/permissions/permissions_api.cc ('k') | chrome/browser/extensions/api/permissions/permissions_api_helpers.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/permissions/permissions_api_helpers.h

diff --git a/chrome/browser/extensions/api/permissions/permissions_api_helpers.h b/chrome/browser/extensions/api/permissions/permissions_api_helpers.h

index becc490ca49d1df3931f83413c5bcc476f28ada8..5284c445a1483508668c08d80b272f4507915e26 100644

--- a/chrome/browser/extensions/api/permissions/permissions_api_helpers.h

+++ b/chrome/browser/extensions/api/permissions/permissions_api_helpers.h

@@ -31,7 +31,7 @@ scoped_ptr<api::permissions::Permissions> PackPermissionSet(

// Creates a permission set from |permissions|. Returns NULL if the permissions

// cannot be converted to a permission set, in which case |error| will be set.

-scoped_refptr<const PermissionSet> UnpackPermissionSet(

+scoped_ptr<const PermissionSet> UnpackPermissionSet(

const api::permissions::Permissions& permissions,

bool allow_file_access,

std::string* error);