chrome/browser/extensions/active_tab_permission_granter.cc - Issue 1349613003: [Extensions] Un-refcount PermissionSet

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/active_tab_permission_granter.cc

Issue 1349613003: [Extensions] Un-refcount PermissionSet (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/active_tab_permission_granter.cc

diff --git a/chrome/browser/extensions/active_tab_permission_granter.cc b/chrome/browser/extensions/active_tab_permission_granter.cc

index cce3f3f9f0974d1729dec1ecb8e45e56d25dbffc..64b79c20c4bbf63f05492d4b30866cd1ce136bf7 100644

--- a/chrome/browser/extensions/active_tab_permission_granter.cc

+++ b/chrome/browser/extensions/active_tab_permission_granter.cc

@@ -104,9 +104,8 @@ void ActiveTabPermissionGranter::GrantIfRequested(const Extension* extension) {

if (!new_apis.empty() || !new_hosts.is_empty()) {

granted_extensions_.Insert(extension);

- scoped_refptr<const PermissionSet> new_permissions =

- new PermissionSet(new_apis, ManifestPermissionSet(),

- new_hosts, URLPatternSet());

+ PermissionSet new_permissions(new_apis, ManifestPermissionSet(), new_hosts,

+ URLPatternSet());

permissions_data->UpdateTabSpecificPermissions(tab_id_, new_permissions);

const content::NavigationEntry* navigation_entry =

web_contents()->GetController().GetVisibleEntry();