[Extensions] Un-refcount PermissionSet

chrome/common/extensions/permissions/settings_override_permission_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // These tests make sure SettingsOverridePermission values are set correctly.
 
 #include "base/basictypes.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/values.h"
 #include "chrome/common/extensions/manifest_tests/chrome_manifest_test.h"
@@ skipping 46 matching lines @@
     ext_manifest.Set(
         manifest_keys::kSettingsOverride, settings_override.release());
 
     ManifestData manifest(&ext_manifest, "test");
     return LoadAndExpectSuccess(manifest);
   }
 };
 
 TEST_F(SettingsOverridePermissionTest, HomePage) {
   scoped_refptr<Extension> extension(GetPermissionSet(kHomepage));
-  scoped_refptr<const PermissionSet> permission_set(
-      extension->permissions_data()->active_permissions());
+  const PermissionSet* permission_set =
+      extension->permissions_data()->active_permissions();
 
 #if defined(OS_WIN)
   EXPECT_TRUE(permission_set->HasAPIPermission(APIPermission::kHomepage));
   VerifyOnePermissionMessage(extension->permissions_data(),
                              "Change your home page to: google.com/");
 #else
   EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kHomepage));
 #endif
 
   EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kStartupPages));
   EXPECT_FALSE(permission_set->HasAPIPermission(
       APIPermission::kSearchProvider));
 }
 
 TEST_F(SettingsOverridePermissionTest, StartupPages) {
   scoped_refptr<Extension> extension(GetPermissionSet(kStartupPages));
-  scoped_refptr<const PermissionSet> permission_set(
-      extension->permissions_data()->active_permissions());
+  const PermissionSet* permission_set =
+      extension->permissions_data()->active_permissions();
 
 #if defined(OS_WIN)
   EXPECT_TRUE(permission_set->HasAPIPermission(APIPermission::kStartupPages));
   VerifyOnePermissionMessage(
       extension->permissions_data(),
       "Change your start page to: startup.com/startup.html");
 #else
   EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kStartupPages));
 #endif
 
   EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kHomepage));
   EXPECT_FALSE(permission_set->HasAPIPermission(
       APIPermission::kSearchProvider));
 }
 
 TEST_F(SettingsOverridePermissionTest, SearchSettings) {
   scoped_refptr<Extension> extension(GetPermissionSet(kSearchProvider));
-  scoped_refptr<const PermissionSet> permission_set(
-      extension->permissions_data()->active_permissions());
+  const PermissionSet* permission_set =
+      extension->permissions_data()->active_permissions();
 
 #if defined(OS_WIN)
   EXPECT_TRUE(permission_set->HasAPIPermission(APIPermission::kSearchProvider));
   VerifyOnePermissionMessage(extension->permissions_data(),
                              "Change your search settings to: google.com");
 #else
   EXPECT_FALSE(
       permission_set->HasAPIPermission(APIPermission::kSearchProvider));
 #endif
 
   EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kHomepage));
   EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kStartupPages));
 }
 
 TEST_F(SettingsOverridePermissionTest, All) {
   scoped_refptr<Extension> extension(GetPermissionSet(
       kSearchProvider | kStartupPages | kHomepage));
-  scoped_refptr<const PermissionSet> permission_set(
-      extension->permissions_data()->active_permissions());
+  const PermissionSet* permission_set =
+      extension->permissions_data()->active_permissions();
 
 #if defined(OS_WIN)
   EXPECT_TRUE(permission_set->HasAPIPermission(APIPermission::kHomepage));
   EXPECT_TRUE(permission_set->HasAPIPermission(APIPermission::kStartupPages));
   EXPECT_TRUE(permission_set->HasAPIPermission(APIPermission::kSearchProvider));
 #else
   EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kHomepage));
   EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kStartupPages));
   EXPECT_FALSE(
       permission_set->HasAPIPermission(APIPermission::kSearchProvider));
 #endif
 }
 
 TEST_F(SettingsOverridePermissionTest, Some) {
   scoped_refptr<Extension> extension(GetPermissionSet(
       kSearchProvider | kHomepage));
-  scoped_refptr<const PermissionSet> permission_set(
-      extension->permissions_data()->active_permissions());
+  const PermissionSet* permission_set =
+      extension->permissions_data()->active_permissions();
 
 #if defined(OS_WIN)
   EXPECT_TRUE(permission_set->HasAPIPermission(APIPermission::kHomepage));
   EXPECT_TRUE(permission_set->HasAPIPermission(APIPermission::kSearchProvider));
 #else
   EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kHomepage));
   EXPECT_FALSE(
       permission_set->HasAPIPermission(APIPermission::kSearchProvider));
 #endif
 
   EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kStartupPages));
 }
 
 }  // namespace
 
 }  // namespace extensions