[Extensions] Un-refcount PermissionSet

chrome/browser/extensions/bundle_installer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/bundle_installer.h"
 
 #include <algorithm>
 #include <string>
 #include <vector>
 
@@ skipping 243 matching lines @@
   ShowPrompt();
 }
 
 void BundleInstaller::ShowPrompt() {
   // Abort if we couldn't create any Extensions out of the manifests.
   if (dummy_extensions_.empty()) {
     approval_callback_.Run(APPROVAL_ERROR);
     return;
   }
 
-  scoped_refptr<const PermissionSet> permissions =
-      dummy_extensions_[0]->permissions_data()->active_permissions();
-  for (size_t i = 1; i < dummy_extensions_.size(); ++i) {
+  scoped_ptr<const PermissionSet> permissions;
+  PermissionSet empty;
+  for (size_t i = 0; i < dummy_extensions_.size(); ++i) {
+    // Using "permissions ? *permissions : PermissionSet()" tries to do a copy,
+    // and doesn't compile. Use a more verbose, but compilable, workaround.
     permissions = PermissionSet::CreateUnion(
-        *permissions,
+        permissions ? *permissions : empty,
         *dummy_extensions_[i]->permissions_data()->active_permissions());
   }
 
   if (g_auto_approve_for_test == PROCEED) {
     InstallUIProceed();
   } else if (g_auto_approve_for_test == ABORT) {
     InstallUIAbort(true);
   } else {
     Browser* browser = browser_;
     if (!browser) {
       // The browser that we got initially could have gone away during our
       // thread hopping.
       browser = chrome::FindLastActiveWithProfile(profile_, host_desktop_type_);
     }
     content::WebContents* web_contents = NULL;
     if (browser)
       web_contents = browser->tab_strip_model()->GetActiveWebContents();
     install_ui_.reset(new ExtensionInstallPrompt(web_contents));
     if (delegated_username_.empty()) {
-      install_ui_->ConfirmBundleInstall(this, &icon_, permissions.get());
+      install_ui_->ConfirmBundleInstall(this, &icon_, permissions.Pass());
     } else {
       install_ui_->ConfirmPermissionsForDelegatedBundleInstall(
-          this, delegated_username_, &icon_, permissions.get());
+          this, delegated_username_, &icon_, permissions.Pass());
     }
   }
 }
 
 void BundleInstaller::ShowInstalledBubbleIfDone() {
   // We're ready to show the installed bubble when no items are pending.
   if (HasItemWithState(Item::STATE_PENDING))
     return;
 
   if (browser_)
@@ skipping 57 matching lines @@
 
   ShowInstalledBubbleIfDone();
 }
 
 void BundleInstaller::OnBrowserRemoved(Browser* browser) {
   if (browser_ == browser)
     browser_ = nullptr;
 }
 
 }  // namespace extensions