Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1275)

Issue 13496017: filemanager: Pass the entire Drive path to DirectoryModel for setupCurrentDirectory. (Closed)

Created:
7 years, 8 months ago by Haruki Sato
Modified:
7 years, 8 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

filemanager: Pass the entire Drive path to DirectoryModel for setupCurrentDirectory. This can restore the original behavior. Note that Directory contents do not resolve the sub-directories in /drive/root and the UI cannot open a deep subdirectory in Drive (http://crbug.com/227530). BUG=227488 TEST=Open Google Drive in Files App, and reload the app and verify the directory contents properly opened. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192804

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove garbage line. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/file_manager/js/file_manager.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Haruki Sato
I think this works and we can investigate further improvement later. Do you think this ...
7 years, 8 months ago (2013-04-08 09:59:55 UTC) #1
yoshiki
Thanks! LGTM. https://codereview.chromium.org/13496017/diff/1/chrome/browser/resources/file_manager/js/file_manager.js File chrome/browser/resources/file_manager/js/file_manager.js (right): https://codereview.chromium.org/13496017/diff/1/chrome/browser/resources/file_manager/js/file_manager.js#newcode1363 chrome/browser/resources/file_manager/js/file_manager.js:1363: // this.directoryModel_.setupPath(RootDirectory.DRIVE); nit: remove this line.
7 years, 8 months ago (2013-04-08 10:05:31 UTC) #2
Haruki Sato
https://codereview.chromium.org/13496017/diff/1/chrome/browser/resources/file_manager/js/file_manager.js File chrome/browser/resources/file_manager/js/file_manager.js (right): https://codereview.chromium.org/13496017/diff/1/chrome/browser/resources/file_manager/js/file_manager.js#newcode1363 chrome/browser/resources/file_manager/js/file_manager.js:1363: // this.directoryModel_.setupPath(RootDirectory.DRIVE); On 2013/04/08 10:05:31, yoshiki wrote: > nit: ...
7 years, 8 months ago (2013-04-08 10:16:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haruki@chromium.org/13496017/3
7 years, 8 months ago (2013-04-08 10:16:34 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-08 10:23:48 UTC) #5
Haruki Sato
7 years, 8 months ago (2013-04-08 11:26:55 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r192804 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698