Issue 13496008: fix bogus uses of preparser API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13496008: fix bogus uses of preparser API (Closed)

Created:
7 years, 8 months ago by wingo

Modified:
7 years, 8 months ago

Reviewers:
Michael Starzinger, Jakob Kummerow

Base URL:
git://github.com/v8/v8.git@master

Visibility:
Public.

More Reviews

Description

Fix bogus uses of preparser API * src/api.cc (ScriptData::PreCompile): Fix bogus use of bogus value for preparsing flags by removing those arguments, which were always zero. * src/parser.h * src/parser.cc (ParserApi::PreParse): Remove extension and flags arguments, both of which were either always 0 or incorrectly used. * test/cctest/test-parsing.cc (RegressChromium62639, Regress928): Fix more bogus uses of preparser api. BUG= Committed: http://code.google.com/p/v8/source/detail?r=14140

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -14 lines)			Patch
M	src/api.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/parser.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	src/parser.cc	View	1 chunk	+3 lines, -5 lines	0 comments	Download
M	test/cctest/test-parsing.cc	View	2 chunks	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

wingo

Turns out both uses of ParserApi::PreParse were passing "flags" values of an incorrect type. Yay ...

7 years, 8 months ago (2013-04-04 13:57:52 UTC) #1

Michael Starzinger

7 years, 8 months ago (2013-04-04 14:34:31 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r14140 (presubmit successful).

Expand Messages | Collapse Messages