Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1746)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/WebActionModeCallback.java

Issue 1349563003: Implement Android M text process action in ActionMode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/WebActionModeCallback.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/WebActionModeCallback.java b/content/public/android/java/src/org/chromium/content/browser/WebActionModeCallback.java
index 082068a4daff3edd92c064299dd81658a62a06ed..4ca85e2f9fb64073be49943191c32a9b31bf1b73 100644
--- a/content/public/android/java/src/org/chromium/content/browser/WebActionModeCallback.java
+++ b/content/public/android/java/src/org/chromium/content/browser/WebActionModeCallback.java
@@ -53,6 +53,11 @@ public class WebActionModeCallback implements ActionMode.Callback {
void share();
/**
+ * Perform a translate action.
+ */
+ void translate();
+
+ /**
* Perform a search action.
*/
void search();
@@ -79,6 +84,11 @@ public class WebActionModeCallback implements ActionMode.Callback {
boolean isShareAvailable();
/**
+ * @return Whether or not translate is available.
+ */
+ boolean isTranslateAvailable();
+
+ /**
* @return Whether or not web search is available.
*/
boolean isWebSearchAvailable();
@@ -178,6 +188,10 @@ public class WebActionModeCallback implements ActionMode.Callback {
menu.removeItem(R.id.select_action_menu_share);
}
+ if (!mActionHandler.isTranslateAvailable()) {
+ menu.removeItem(R.id.select_action_menu_translate);
+ }
+
if (mEditable || mActionHandler.isIncognito() || !mActionHandler.isWebSearchAvailable()) {
menu.removeItem(R.id.select_action_menu_web_search);
}
@@ -211,6 +225,9 @@ public class WebActionModeCallback implements ActionMode.Callback {
} else if (id == R.id.select_action_menu_web_search) {
mActionHandler.search();
mode.finish();
+ } else if (id == R.id.select_action_menu_translate) {
+ mActionHandler.translate();
+ mode.finish();
} else {
return false;
}

Powered by Google App Engine
This is Rietveld 408576698