Implement Android M text process action in ActionMode

content/public/android/java/src/org/chromium/content/browser/WebActionModeCallback.java

Index: content/public/android/java/src/org/chromium/content/browser/WebActionModeCallback.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/WebActionModeCallback.java b/content/public/android/java/src/org/chromium/content/browser/WebActionModeCallback.java
index 082068a4daff3edd92c064299dd81658a62a06ed..d6eab6eabf815457741449e2831fabd057ac3bd1 100644
--- a/content/public/android/java/src/org/chromium/content/browser/WebActionModeCallback.java
+++ b/content/public/android/java/src/org/chromium/content/browser/WebActionModeCallback.java
@@ -4,10 +4,15 @@
 
 package org.chromium.content.browser;
 
+import android.annotation.TargetApi;
 import android.content.ClipboardManager;
 import android.content.Context;
+import android.content.Intent;
+import android.content.pm.PackageManager;
+import android.content.pm.ResolveInfo;
 import android.content.res.Resources;
 import android.graphics.Rect;
+import android.os.Build;
 import android.view.ActionMode;
 import android.view.Menu;
 import android.view.MenuInflater;
@@ -17,6 +22,8 @@ import android.view.View;
 import org.chromium.content.R;
 import org.chromium.ui.base.DeviceFormFactor;
 
+import java.util.List;
+
 /**
  * An ActionMode.Callback for in-page web content selection. This class handles both the editable
  * and non-editable cases.
@@ -53,6 +60,11 @@ public class WebActionModeCallback implements ActionMode.Callback {
         void share();
 
         /**
+         * Perform a processText action (translating the text, for example).
+         */
+        void processText(Intent intent);
+
+        /**
          * Perform a search action.
          */
         void search();
@@ -157,12 +169,15 @@ public class WebActionModeCallback implements ActionMode.Callback {
             new MenuInflater(getContext()).inflate(R.menu.select_action_menu, menu);
         }
 
+        initializeTextProcessingMenu(menu);
+
         if (mIsInsertion) {
             menu.removeItem(R.id.select_action_menu_select_all);
             menu.removeItem(R.id.select_action_menu_cut);
             menu.removeItem(R.id.select_action_menu_copy);
             menu.removeItem(R.id.select_action_menu_share);
             menu.removeItem(R.id.select_action_menu_web_search);
+            menu.removeGroup(R.id.select_action_menu_text_processing_menus);
             return;
         }
 
@@ -185,6 +200,7 @@ public class WebActionModeCallback implements ActionMode.Callback {
         if (mIsPasswordType) {
             menu.removeItem(R.id.select_action_menu_copy);
             menu.removeItem(R.id.select_action_menu_cut);
+            menu.removeGroup(R.id.select_action_menu_text_processing_menus);
         }
     }
 
@@ -193,6 +209,7 @@ public class WebActionModeCallback implements ActionMode.Callback {
         if (mIsDestroyed) return true;
 
         int id = item.getItemId();
+        int groupId = item.getGroupId();
 
         if (id == R.id.select_action_menu_select_all) {
             mActionHandler.selectAll();
@@ -211,6 +228,9 @@ public class WebActionModeCallback implements ActionMode.Callback {
         } else if (id == R.id.select_action_menu_web_search) {
             mActionHandler.search();
             mode.finish();
+        } else if (groupId == R.id.select_action_menu_text_processing_menus) {
+            mActionHandler.processText(item.getIntent());
+            mode.finish();
         } else {
             return false;
         }
@@ -242,4 +262,36 @@ public class WebActionModeCallback implements ActionMode.Callback {
                 getContext().getSystemService(Context.CLIPBOARD_SERVICE);
         return clipMgr.hasPrimaryClip();
     }
+
+    /**
+     * Intialize the menu items for processing text, if there is any.
+     */
+    private void initializeTextProcessingMenu(Menu menu) {
+        if (Build.VERSION.SDK_INT < Build.VERSION_CODES.M) return;

[jdduke (slow), 2015/09/24 20:05:14]

Oh, did we decide if we wanted this only for floating ActionModes? Because we
can get both types on M.

[hush (inactive), 2015/09/25 23:05:30]

I chatted with the feature owner in Android. He is not sure himself. So I just
made a test app myself with customized text view in it.
Both types of ActionModes should get "Text processing" actions for TextView. So
let's  just do that WebView too (which is what's done right now)

+
+        PackageManager packageManager = getContext().getPackageManager();
+        List<ResolveInfo> supportedActivities =

[jdduke (slow), 2015/09/24 20:01:21]

How expensive is this query? Is it worth early-outing for insertion/password
fields?

[hush (inactive), 2015/09/25 23:05:30]

Not sure how expensive it is but the function is pretty complicated.
https://cs.corp.google.com/#android/frameworks/base/services/core/java/com/an...

I will just put initializeTextProcessingMenu in the end of createActionMenu

[jdduke (slow), 2015/09/25 23:36:00]

Sounds good, so we'll just not call this function if it's a password or
insertion type?

[hush (inactive), 2015/09/25 23:47:42]

Yes.

+                packageManager.queryIntentActivities(createProcessTextIntent(), 0);
+        for (int i = 0; i < supportedActivities.size(); i++) {
+            ResolveInfo resolveInfo = supportedActivities.get(i);
+            CharSequence label = resolveInfo.loadLabel(getContext().getPackageManager());
+            menu.add(R.id.select_action_menu_text_processing_menus, Menu.NONE, i, label)
+                    .setIntent(createProcessTextIntentForResolveInfo(resolveInfo))
+                    .setShowAsAction(MenuItem.SHOW_AS_ACTION_IF_ROOM);
+        }
+    }
+
+    @TargetApi(Build.VERSION_CODES.M)
+    private Intent createProcessTextIntent() {
+        return new Intent().setAction(Intent.ACTION_PROCESS_TEXT).setType("text/plain");
+    }
+
+    @TargetApi(Build.VERSION_CODES.M)
+    private Intent createProcessTextIntentForResolveInfo(ResolveInfo info) {
+        return createProcessTextIntent()
+            // TODO(hush crbug.com/521027): should be !isSelectionEditable(),

[jdduke (slow), 2015/09/24 20:01:21]

Please move the |true| boolean arg out and assign it a name before passing in,
with the comment there. Also, not sure I've seen the crbug in the TODO()
portion, maybe put that at the end, TODO(hush): *, crbug.com/*.

[hush (inactive), 2015/09/25 23:05:30]

Done.

+            // when WebView supports replacing the text.
+                .putExtra(Intent.EXTRA_PROCESS_TEXT_READONLY, true)
+                .setClassName(info.activityInfo.packageName, info.activityInfo.name);
+    }
 }