Implement Android M text process action in ActionMode

content/public/android/java/src/org/chromium/content/browser/WebActionModeCallback.java

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.content.browser;
 
 import android.content.ClipboardManager;
 import android.content.Context;
+import android.content.Intent;
 import android.content.res.Resources;
 import android.graphics.Rect;
 import android.view.ActionMode;
 import android.view.Menu;
 import android.view.MenuInflater;
 import android.view.MenuItem;
 import android.view.View;
 
 import org.chromium.content.R;
 import org.chromium.ui.base.DeviceFormFactor;
@@ skipping 27 matching lines @@
          * Perform a paste action.
          */
         void paste();
 
         /**
          * Perform a share action.
          */
         void share();
 
         /**
+         * Perform a processText action (translating the text, for example).
+         */
+        void processText(Intent intent);
+
+        /**
+         * Intialize the menu items for processing text, if there is any.
+         */
+        void initializeTextProcessingMenu(Menu menu);

[Ted C, 2015/09/17 20:34:57]

To me, this function doesn't seem like it belongs on the ActionHandler but
should just live within this class.

If we want the embedder to have the ability to toggle support for this, I think
we should have supportsTextProcessIntents as a function to keep it consistent
with the isSelectionEditable as below.  But for now, I would just include it all
in this file.

[hush (inactive), 2015/09/17 21:30:52]

Okay. I just moved the related logic from contentviewcore to this class.
I don't add supportsTextProcessIntents() yet. I haven't seen any use case that
yet. People can add it easily when it is necessary.

+
+        /**
          * Perform a search action.
          */
         void search();
 
         /**
          * @return true iff the current selection is editable (e.g. text within an input field).
          */
         boolean isSelectionEditable();
 
         /**
@@ skipping 84 matching lines @@
         try {
             mode.getMenuInflater().inflate(R.menu.select_action_menu, menu);
         } catch (Resources.NotFoundException e) {
             // TODO(tobiasjs) by the time we get here we have already
             // caused a resource loading failure to be logged. WebView
             // resource access needs to be improved so that this
             // logspam can be avoided.
             new MenuInflater(getContext()).inflate(R.menu.select_action_menu, menu);
         }
 
+        mActionHandler.initializeTextProcessingMenu(menu);
+
         if (mIsInsertion) {
             menu.removeItem(R.id.select_action_menu_select_all);
             menu.removeItem(R.id.select_action_menu_cut);
             menu.removeItem(R.id.select_action_menu_copy);
             menu.removeItem(R.id.select_action_menu_share);
             menu.removeItem(R.id.select_action_menu_web_search);
+            menu.removeGroup(R.id.select_action_menu_text_processing_menus);
             return;
         }
 
         if (!mEditable || !canPaste()) {
             menu.removeItem(R.id.select_action_menu_paste);
         }
 
         if (!mEditable) {
             menu.removeItem(R.id.select_action_menu_cut);
         }
 
         if (mEditable || !mActionHandler.isShareAvailable()) {
             menu.removeItem(R.id.select_action_menu_share);
         }
 
         if (mEditable || mActionHandler.isIncognito() || !mActionHandler.isWebSearchAvailable()) {
             menu.removeItem(R.id.select_action_menu_web_search);
         }
 
         if (mIsPasswordType) {
             menu.removeItem(R.id.select_action_menu_copy);
             menu.removeItem(R.id.select_action_menu_cut);
+            menu.removeGroup(R.id.select_action_menu_text_processing_menus);
         }
     }
 
     @Override
     public boolean onActionItemClicked(ActionMode mode, MenuItem item) {
         if (mIsDestroyed) return true;
 
         int id = item.getItemId();
+        int groupId = item.getGroupId();
 
         if (id == R.id.select_action_menu_select_all) {
             mActionHandler.selectAll();
         } else if (id == R.id.select_action_menu_cut) {
             mActionHandler.cut();
             mode.finish();
         } else if (id == R.id.select_action_menu_copy) {
             mActionHandler.copy();
             mode.finish();
         } else if (id == R.id.select_action_menu_paste) {
             mActionHandler.paste();
             mode.finish();
         } else if (id == R.id.select_action_menu_share) {
             mActionHandler.share();
             mode.finish();
         } else if (id == R.id.select_action_menu_web_search) {
             mActionHandler.search();
             mode.finish();
+        } else if (groupId == R.id.select_action_menu_text_processing_menus) {
+            mActionHandler.processText(item.getIntent());
+            mode.finish();
         } else {
             return false;
         }
         return true;
     }
 
     @Override
     public void onDestroyActionMode(ActionMode mode) {
         mIsDestroyed = true;
         mActionHandler.onDestroyActionMode();
@@ skipping 12 matching lines @@
         if (mIsDestroyed) return;
         mActionHandler.onGetContentRect(outRect);
     }
 
     private boolean canPaste() {
         ClipboardManager clipMgr = (ClipboardManager)
                 getContext().getSystemService(Context.CLIPBOARD_SERVICE);
         return clipMgr.hasPrimaryClip();
     }
 }