LayoutTests/fast/css/invalidation/targeted-class-id.html - Issue 1349543004: CSS: Avoid invalidating style when only descendants need updating

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/css/invalidation/targeted-class-id.html

Issue 1349543004: CSS: Avoid invalidating style when only descendants need updating (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: invalidatesSelf Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/css/invalidation/targeted-class-host-pseudo-expected.txt ('k') | LayoutTests/fast/css/invalidation/targeted-class-id-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../../../resources/js-test.js"></script>	2 <script src="../../../resources/js-test.js"></script>

3 <style>	3 <style>

4 .a1 #b1 { background-color: green }	4 .a1 #b1 { background-color: green }

5 .a2 div + #b2 { background-color: green }	5 .a2 div + #b2 { background-color: green }

6 </style>	6 </style>

7 <div id="t1">	7 <div id="t1">

8 <div></div>	8 <div></div>

9 <div id="b1"></div>	9 <div id="b1"></div>

10 </div>	10 </div>

(...skipping 10 matching lines...) Expand all Loading...
21 var b1 = document.getElementById("b1");	21 var b1 = document.getElementById("b1");

22 var b2 = document.getElementById("b2");	22 var b2 = document.getElementById("b2");

23	23

24 shouldBe("getComputedStyle(b1, null).backgroundColor", "transparent");	24 shouldBe("getComputedStyle(b1, null).backgroundColor", "transparent");

25 shouldBe("getComputedStyle(b2, null).backgroundColor", "transparent");	25 shouldBe("getComputedStyle(b2, null).backgroundColor", "transparent");

26	26

27 document.body.offsetTop; // Force style recalc.	27 document.body.offsetTop; // Force style recalc.

28	28

29 document.getElementById("t1").className = "a1";	29 document.getElementById("t1").className = "a1";

30 if (window.internals)	30 if (window.internals)

31 shouldBe("internals.updateStyleAndReturnAffectedElementCount()", "2");	31 shouldBe("internals.updateStyleAndReturnAffectedElementCount()", "1");

32 shouldBe("getComputedStyle(b1, null).backgroundColor", "green");	32 shouldBe("getComputedStyle(b1, null).backgroundColor", "green");

33	33

34 document.body.offsetLeft; // force style recalc.	34 document.body.offsetLeft; // force style recalc.

35	35

36 document.getElementById("t2").className = "a2";	36 document.getElementById("t2").className = "a2";

37 if (window.internals)	37 if (window.internals)

38 shouldBe("internals.updateStyleAndReturnAffectedElementCount()", "2");	38 shouldBe("internals.updateStyleAndReturnAffectedElementCount()", "1");

39 shouldBe("getComputedStyle(b2, null).backgroundColor", "green");	39 shouldBe("getComputedStyle(b2, null).backgroundColor", "green");

40	40

41 </script>	41 </script>

OLD	NEW