Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1349493004: IntToString() signedness fixes for //dbus (Closed)

Created:
5 years, 3 months ago by Adam Rice
Modified:
5 years, 3 months ago
Reviewers:
stevenjb
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

IntToString() signedness fixes for //dbus Use UintToString() rather than IntToString() for unsigned types, to improve correctness. Also replace some trivial usages of StringPrintf() with the appropriate IntToString() variants, to improve performance, code size and type safety. No behavioural changes are intended. BUG=505479 TEST=dbus_unittests Committed: https://crrev.com/19b947df2525b66bee8fae31de23dba12423703a Cr-Commit-Position: refs/heads/master@{#349785}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M dbus/message.cc View 6 chunks +10 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Adam Rice
5 years, 3 months ago (2015-09-18 21:18:54 UTC) #2
stevenjb
lgtm
5 years, 3 months ago (2015-09-18 21:26:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1349493004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1349493004/1
5 years, 3 months ago (2015-09-18 21:56:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-18 22:26:17 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-18 22:27:00 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/19b947df2525b66bee8fae31de23dba12423703a
Cr-Commit-Position: refs/heads/master@{#349785}

Powered by Google App Engine
This is Rietveld 408576698